Patchwork [16/22] data: klog.json: Add support for the ACPI memory hotplug messages

login
register
mail settings
Submitter Colin King
Date Nov. 2, 2012, 5:15 p.m.
Message ID <1351876532-21869-17-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/196625/
State Accepted
Headers show

Comments

Colin King - Nov. 2, 2012, 5:15 p.m.
From: Colin Ian King <colin.king@canonical.com>

Add support to check for messages in drivers/acpi/acpi_memhotplug.c

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |   64 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)
Keng-Yu Lin - Nov. 7, 2012, 4:18 a.m.
On Sat, Nov 3, 2012 at 1:15 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in drivers/acpi/acpi_memhotplug.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json |   64 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 64 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 35f83be..4abb0fb 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -80,6 +80,70 @@
>     "compare_mode": "string",
>     "log_level": "LOG_LEVEL_MEDIUM",
>     "tag": "FWTS_TAG_ACPI",
> +   "pattern": "memory_hp:Error in acpi_memory_enable_device",
> +   "advice": "Adding a hotplug memory device failed because.",
> +   "label": "KlogAcpiHotPlugAddMemDeviceFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_INFO",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "memory_hp:Disable memory device",
> +   "advice": "An ACPI notify eject request occurred to disable a memory device.",
> +   "label": "KlogAcpiHotPlugNotifyDisableOkay"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "memory_hp:Driver Data is NULL",
> +   "advice": "An ACPI notify eject request failed because the device data is NULL.",
> +   "label": "KlogAcpiHotPlugNotifyEjectDataNull"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "Device doesn't exist",
> +   "advice": "An ACPI notify eject request failed because the device does not exist.",
> +   "label": "KlogAcpiHotPlugNotifyEjectDeviceNotExist"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "memory_hp:Cannot enable memory device",
> +   "advice": "Memory device notify failed because it could not enabled the memory device.",
> +   "label": "KlogAcpiHotPlugEnableFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "memory_hp:Cannot find driver data",
> +   "advice": "Memory device notify failed because it could not find the relevant driver data for this device.",
> +   "label": "KlogAcpiHotPlugDeviceNotify"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "memory_hp:add_memory failed",
> +   "advice": "Failed to add memory device, add_memory() failed for some reason.",
> +   "label": "KlogAcpiHotPlugAddMemoryFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "memory_hp:get_device_resources failed",
> +   "advice": "The devices resources could not be determined from the relevant ACPI _CRS control and so the memory device could not be enabled.",
> +   "label": "KlogAcpiHotPlugCrsFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
>     "pattern": "Fatal opcode executed",
>     "advice": "An ACPI AML fatal opcode was executed and the kernel has trapped this signal. It could be because of faulty control method code.",
>     "label": "KlogAcpiFatalOpcodeSignal"
> --
> 1.7.10.4
>
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - Nov. 21, 2012, 2:58 a.m.
On 11/03/2012 01:15 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in drivers/acpi/acpi_memhotplug.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json |   64 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 64 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 35f83be..4abb0fb 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -80,6 +80,70 @@
>      "compare_mode": "string",
>      "log_level": "LOG_LEVEL_MEDIUM",
>      "tag": "FWTS_TAG_ACPI",
> +   "pattern": "memory_hp:Error in acpi_memory_enable_device",
> +   "advice": "Adding a hotplug memory device failed because.",
> +   "label": "KlogAcpiHotPlugAddMemDeviceFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_INFO",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "memory_hp:Disable memory device",
> +   "advice": "An ACPI notify eject request occurred to disable a memory device.",
> +   "label": "KlogAcpiHotPlugNotifyDisableOkay"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "memory_hp:Driver Data is NULL",
> +   "advice": "An ACPI notify eject request failed because the device data is NULL.",
> +   "label": "KlogAcpiHotPlugNotifyEjectDataNull"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "Device doesn't exist",
> +   "advice": "An ACPI notify eject request failed because the device does not exist.",
> +   "label": "KlogAcpiHotPlugNotifyEjectDeviceNotExist"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "memory_hp:Cannot enable memory device",
> +   "advice": "Memory device notify failed because it could not enabled the memory device.",
> +   "label": "KlogAcpiHotPlugEnableFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "memory_hp:Cannot find driver data",
> +   "advice": "Memory device notify failed because it could not find the relevant driver data for this device.",
> +   "label": "KlogAcpiHotPlugDeviceNotify"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "memory_hp:add_memory failed",
> +   "advice": "Failed to add memory device, add_memory() failed for some reason.",
> +   "label": "KlogAcpiHotPlugAddMemoryFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "memory_hp:get_device_resources failed",
> +   "advice": "The devices resources could not be determined from the relevant ACPI _CRS control and so the memory device could not be enabled.",
> +   "label": "KlogAcpiHotPlugCrsFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_MEDIUM",
> +   "tag": "FWTS_TAG_ACPI",
>      "pattern": "Fatal opcode executed",
>      "advice": "An ACPI AML fatal opcode was executed and the kernel has trapped this signal. It could be because of faulty control method code.",
>      "label": "KlogAcpiFatalOpcodeSignal"
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index 35f83be..4abb0fb 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -80,6 +80,70 @@ 
    "compare_mode": "string",
    "log_level": "LOG_LEVEL_MEDIUM",
    "tag": "FWTS_TAG_ACPI",
+   "pattern": "memory_hp:Error in acpi_memory_enable_device",
+   "advice": "Adding a hotplug memory device failed because.",
+   "label": "KlogAcpiHotPlugAddMemDeviceFailed"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_INFO",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "memory_hp:Disable memory device",
+   "advice": "An ACPI notify eject request occurred to disable a memory device.",
+   "label": "KlogAcpiHotPlugNotifyDisableOkay"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_MEDIUM",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "memory_hp:Driver Data is NULL",
+   "advice": "An ACPI notify eject request failed because the device data is NULL.",
+   "label": "KlogAcpiHotPlugNotifyEjectDataNull"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_MEDIUM",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "Device doesn't exist",
+   "advice": "An ACPI notify eject request failed because the device does not exist.",
+   "label": "KlogAcpiHotPlugNotifyEjectDeviceNotExist"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_MEDIUM",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "memory_hp:Cannot enable memory device",
+   "advice": "Memory device notify failed because it could not enabled the memory device.",
+   "label": "KlogAcpiHotPlugEnableFailed"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_MEDIUM",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "memory_hp:Cannot find driver data",
+   "advice": "Memory device notify failed because it could not find the relevant driver data for this device.",
+   "label": "KlogAcpiHotPlugDeviceNotify"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_MEDIUM",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "memory_hp:add_memory failed",
+   "advice": "Failed to add memory device, add_memory() failed for some reason.",
+   "label": "KlogAcpiHotPlugAddMemoryFailed"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_MEDIUM",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "memory_hp:get_device_resources failed",
+   "advice": "The devices resources could not be determined from the relevant ACPI _CRS control and so the memory device could not be enabled.",
+   "label": "KlogAcpiHotPlugCrsFailed"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_MEDIUM",
+   "tag": "FWTS_TAG_ACPI",
    "pattern": "Fatal opcode executed",
    "advice": "An ACPI AML fatal opcode was executed and the kernel has trapped this signal. It could be because of faulty control method code.",
    "label": "KlogAcpiFatalOpcodeSignal"