Patchwork [22/22] data: klog.json: Add support for the ACPI PCI slot messages

login
register
mail settings
Submitter Colin King
Date Nov. 2, 2012, 5:15 p.m.
Message ID <1351876532-21869-23-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/196622/
State Accepted
Headers show

Comments

Colin King - Nov. 2, 2012, 5:15 p.m.
From: Colin Ian King <colin.king@canonical.com>

Add support to check for messages in drivers/acpi/pci_slot.c

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |   24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
Keng-Yu Lin - Nov. 7, 2012, 4:20 a.m.
On Sat, Nov 3, 2012 at 1:15 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in drivers/acpi/pci_slot.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json |   24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index ef82821..66442de 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -80,6 +80,30 @@
>     "compare_mode": "regex",
>     "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI",
> +   "pattern": "pci_create_slot returned",
> +   "advice": "A PCI slot could not be register because a call to pci_create_slot() failed.",
> +   "label": "KlogAcpiPciSlot"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "walk_p2p_bridge failure",
> +   "advice": "Traversing the PCI root bridge failed because of an error walking the P2P bridge.",
> +   "label": "KlogAcpiPciSlot"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "register_slot failure",
> +   "advice": "Adding a PCI slot failed because traversing the PCI root bridge failed.",
> +   "label": "KlogAcpiPciSlot"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
>     "pattern": "_PRS resource type .* isn't an IRQ",
>     "advice": "The ACPI _PRS resource type was expected to be an IRQ type and was not.",
>     "label": "KlogAcpiPciLinkPrsIrq"
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - Nov. 21, 2012, 3 a.m.
On 11/03/2012 01:15 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in drivers/acpi/pci_slot.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json |   24 ++++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index ef82821..66442de 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -80,6 +80,30 @@
>      "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI",
> +   "pattern": "pci_create_slot returned",
> +   "advice": "A PCI slot could not be register because a call to pci_create_slot() failed.",
> +   "label": "KlogAcpiPciSlot"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "walk_p2p_bridge failure",
> +   "advice": "Traversing the PCI root bridge failed because of an error walking the P2P bridge.",
> +   "label": "KlogAcpiPciSlot"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "register_slot failure",
> +   "advice": "Adding a PCI slot failed because traversing the PCI root bridge failed.",
> +   "label": "KlogAcpiPciSlot"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
>      "pattern": "_PRS resource type .* isn't an IRQ",
>      "advice": "The ACPI _PRS resource type was expected to be an IRQ type and was not.",
>      "label": "KlogAcpiPciLinkPrsIrq"
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index ef82821..66442de 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -80,6 +80,30 @@ 
    "compare_mode": "regex",
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI",
+   "pattern": "pci_create_slot returned",
+   "advice": "A PCI slot could not be register because a call to pci_create_slot() failed.",
+   "label": "KlogAcpiPciSlot"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "walk_p2p_bridge failure",
+   "advice": "Traversing the PCI root bridge failed because of an error walking the P2P bridge.",
+   "label": "KlogAcpiPciSlot"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "register_slot failure",
+   "advice": "Adding a PCI slot failed because traversing the PCI root bridge failed.",
+   "label": "KlogAcpiPciSlot"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
    "pattern": "_PRS resource type .* isn't an IRQ",
    "advice": "The ACPI _PRS resource type was expected to be an IRQ type and was not.",
    "label": "KlogAcpiPciLinkPrsIrq"