Patchwork [08/22] data: klog.json: Add support for the ACPI Docking handler

login
register
mail settings
Submitter Colin King
Date Nov. 2, 2012, 5:15 p.m.
Message ID <1351876532-21869-9-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/196613/
State Accepted
Headers show

Comments

Colin King - Nov. 2, 2012, 5:15 p.m.
From: Colin Ian King <colin.king@canonical.com>

Add support to check for messages in drivers/acpi/dock.c

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |   32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
Keng-Yu Lin - Nov. 7, 2012, 4:16 a.m.
On Sat, Nov 3, 2012 at 1:15 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in drivers/acpi/dock.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json |   32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index d85423f..f828326 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -79,6 +79,38 @@
>    {
>     "compare_mode": "string",
>     "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_DOCK",
> +   "pattern": "Unable to undock",
> +   "advice": "An undock event was requested but the machine still seems to be docked.",
> +   "label": "KlogAcpiDockCannotUndock"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_DOCK",
> +   "pattern": "Unable to dock",
> +   "advice": "A dock notify event was handled but the machine still seems to be undocked.",
> +   "label": "KlogAcpiDockCannotDoct"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_DOCK",
> +   "pattern": "Unknown dock event",
> +   "advice": "A dock notify event was handled, but the type of notify event was not recognised.",
> +   "label": "KlogAcpiDockEvent"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_DOCK",
> +   "pattern": ".* encountered error .*",
> +   "advice": "An error occurred when trying to add a new dock station device.",
> +   "label": "KlogAcpiDockAdd"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_ACPI_BUTTON",
>     "pattern": "More than one Lid device found",
>     "advice": "Failed to add a Lid device because one already exists.  The kernel does not support more than one Lid device.",
> --
> 1.7.10.4
>
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - Nov. 21, 2012, 2:55 a.m.
On 11/03/2012 01:15 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in drivers/acpi/dock.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json |   32 ++++++++++++++++++++++++++++++++
>   1 file changed, 32 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index d85423f..f828326 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -79,6 +79,38 @@
>     {
>      "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_DOCK",
> +   "pattern": "Unable to undock",
> +   "advice": "An undock event was requested but the machine still seems to be docked.",
> +   "label": "KlogAcpiDockCannotUndock"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_DOCK",
> +   "pattern": "Unable to dock",
> +   "advice": "A dock notify event was handled but the machine still seems to be undocked.",
> +   "label": "KlogAcpiDockCannotDoct"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_DOCK",
> +   "pattern": "Unknown dock event",
> +   "advice": "A dock notify event was handled, but the type of notify event was not recognised.",
> +   "label": "KlogAcpiDockEvent"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_DOCK",
> +   "pattern": ".* encountered error .*",
> +   "advice": "An error occurred when trying to add a new dock station device.",
> +   "label": "KlogAcpiDockAdd"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_ACPI_BUTTON",
>      "pattern": "More than one Lid device found",
>      "advice": "Failed to add a Lid device because one already exists.  The kernel does not support more than one Lid device.",
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index d85423f..f828326 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -79,6 +79,38 @@ 
   {
    "compare_mode": "string",
    "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_ACPI_DOCK",
+   "pattern": "Unable to undock",
+   "advice": "An undock event was requested but the machine still seems to be docked.",
+   "label": "KlogAcpiDockCannotUndock"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_ACPI_DOCK",
+   "pattern": "Unable to dock",
+   "advice": "A dock notify event was handled but the machine still seems to be undocked.",
+   "label": "KlogAcpiDockCannotDoct"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_ACPI_DOCK",
+   "pattern": "Unknown dock event",
+   "advice": "A dock notify event was handled, but the type of notify event was not recognised.",
+   "label": "KlogAcpiDockEvent"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_ACPI_DOCK",
+   "pattern": ".* encountered error .*",
+   "advice": "An error occurred when trying to add a new dock station device.",
+   "label": "KlogAcpiDockAdd"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_ACPI_BUTTON",
    "pattern": "More than one Lid device found",
    "advice": "Failed to add a Lid device because one already exists.  The kernel does not support more than one Lid device.",