Patchwork [07/22] data: klog.json: Add support for the ACPI Lid errors

login
register
mail settings
Submitter Colin King
Date Nov. 2, 2012, 5:15 p.m.
Message ID <1351876532-21869-8-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/196612/
State Accepted
Headers show

Comments

Colin King - Nov. 2, 2012, 5:15 p.m.
From: Colin Ian King <colin.king@canonical.com>

Add support to check for messages in drivers/acpi/button.c

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)
Keng-Yu Lin - Nov. 7, 2012, 4:16 a.m.
On Sat, Nov 3, 2012 at 1:15 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in drivers/acpi/button.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 447962a..d85423f 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -79,6 +79,22 @@
>    {
>     "compare_mode": "string",
>     "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_BUTTON",
> +   "pattern": "More than one Lid device found",
> +   "advice": "Failed to add a Lid device because one already exists.  The kernel does not support more than one Lid device.",
> +   "label": "KlogAcpiLidMany"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_CRITICAL",
> +   "tag": "FWTS_ACPI_BUTTON",
> +   "pattern": "Unsupported hid",
> +   "advice": "The Lid Hardware ID (HID) is one that the kernel does not recognise and so the Lid device was not added to the system. This can explain why the Lid does not work.",
> +   "label": "KlogAcpiLidBadHid"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_ACPI_CONTAINER",
>     "pattern": "ACPI: device is NULL",
>     "advice": "The kernel count not add a container because the device associated with this was NULL, which is unexexpected.",
> --
> 1.7.10.4
>
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index 447962a..d85423f 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -79,6 +79,22 @@ 
   {
    "compare_mode": "string",
    "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_ACPI_BUTTON",
+   "pattern": "More than one Lid device found",
+   "advice": "Failed to add a Lid device because one already exists.  The kernel does not support more than one Lid device.",
+   "label": "KlogAcpiLidMany"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_CRITICAL",
+   "tag": "FWTS_ACPI_BUTTON",
+   "pattern": "Unsupported hid",
+   "advice": "The Lid Hardware ID (HID) is one that the kernel does not recognise and so the Lid device was not added to the system. This can explain why the Lid does not work.",
+   "label": "KlogAcpiLidBadHid"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_ACPI_CONTAINER",
    "pattern": "ACPI: device is NULL",
    "advice": "The kernel count not add a container because the device associated with this was NULL, which is unexexpected.",