Patchwork [05/22] data: klog.json: Add support for the ACPI arch x86 kernel sleep

login
register
mail settings
Submitter Colin King
Date Nov. 2, 2012, 5:15 p.m.
Message ID <1351876532-21869-6-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/196610/
State Accepted
Headers show

Comments

Colin King - Nov. 2, 2012, 5:15 p.m.
From: Colin Ian King <colin.king@canonical.com>

Add support to check for messages in arch/x86/kernel/acpi/sleep.c

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |    8 ++++++++
 1 file changed, 8 insertions(+)
Keng-Yu Lin - Nov. 7, 2012, 4:16 a.m.
On Sat, Nov 3, 2012 at 1:15 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in arch/x86/kernel/acpi/sleep.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json |    8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index b91bcbe..1f5f522 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -79,6 +79,14 @@
>    {
>     "compare_mode": "string",
>     "log_level": "LOG_LEVEL_CRITICAL",
> +   "tag": "FWTS_ACPI_SUSPEND",
> +   "pattern": "wakeup header does not match",
> +   "advice": "The ACPI suspend wakeup header did not contain the expected header value so the kernel had to abort the suspend. This can happen if the data is corrupted.",
> +   "label": "KlogAcpiSuspendHeader"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_CRITICAL",
>     "tag": "FWTS_ACPI_EVAL",
>     "pattern": "ACPI: not enough elements in _CST",
>     "advice": "_CST returned either a NULL buffer or a type that wasn't an ACPI package or less than 2 elements in the package. The kernel could not evaluate the CPU supported C states supported, meaning that the machine will not run optimally.",
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - Nov. 21, 2012, 2:54 a.m.
On 11/03/2012 01:15 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add support to check for messages in arch/x86/kernel/acpi/sleep.c
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json |    8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index b91bcbe..1f5f522 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -79,6 +79,14 @@
>     {
>      "compare_mode": "string",
>      "log_level": "LOG_LEVEL_CRITICAL",
> +   "tag": "FWTS_ACPI_SUSPEND",
> +   "pattern": "wakeup header does not match",
> +   "advice": "The ACPI suspend wakeup header did not contain the expected header value so the kernel had to abort the suspend. This can happen if the data is corrupted.",
> +   "label": "KlogAcpiSuspendHeader"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_CRITICAL",
>      "tag": "FWTS_ACPI_EVAL",
>      "pattern": "ACPI: not enough elements in _CST",
>      "advice": "_CST returned either a NULL buffer or a type that wasn't an ACPI package or less than 2 elements in the package. The kernel could not evaluate the CPU supported C states supported, meaning that the machine will not run optimally.",
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index b91bcbe..1f5f522 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -79,6 +79,14 @@ 
   {
    "compare_mode": "string",
    "log_level": "LOG_LEVEL_CRITICAL",
+   "tag": "FWTS_ACPI_SUSPEND",
+   "pattern": "wakeup header does not match",
+   "advice": "The ACPI suspend wakeup header did not contain the expected header value so the kernel had to abort the suspend. This can happen if the data is corrupted.",
+   "label": "KlogAcpiSuspendHeader"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_CRITICAL",
    "tag": "FWTS_ACPI_EVAL",
    "pattern": "ACPI: not enough elements in _CST",
    "advice": "_CST returned either a NULL buffer or a type that wasn't an ACPI package or less than 2 elements in the package. The kernel could not evaluate the CPU supported C states supported, meaning that the machine will not run optimally.",