Patchwork [04/22] data: klog.json: Add support for the ACPI processor_idle kernel error messages

login
register
mail settings
Submitter Colin King
Date Nov. 2, 2012, 5:15 p.m.
Message ID <1351876532-21869-5-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/196609/
State Accepted
Headers show

Comments

Colin King - Nov. 2, 2012, 5:15 p.m.
From: Colin Ian King <colin.king@canonical.com>

Add checking for errors produced by ACPI processor_idle

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)
Keng-Yu Lin - Nov. 7, 2012, 4:15 a.m.
On Sat, Nov 3, 2012 at 1:15 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add checking for errors produced by ACPI processor_idle
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 6a5a831..b91bcbe 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -78,6 +78,22 @@
>   [
>    {
>     "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_CRITICAL",
> +   "tag": "FWTS_ACPI_EVAL",
> +   "pattern": "ACPI: not enough elements in _CST",
> +   "advice": "_CST returned either a NULL buffer or a type that wasn't an ACPI package or less than 2 elements in the package. The kernel could not evaluate the CPU supported C states supported, meaning that the machine will not run optimally.",
> +   "label": "KlogAcpiCstElements"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_CRITICAL",
> +   "tag": "FWTS_ACPI_EVAL",
> +   "pattern": "ACPI: count given by _CST is not valid",
> +   "advice": "_CST returned an invalid number of elements, the package a different number of C states to the number of C states that _CST reported. The kernel could not evaluate the CPU supported C states supported, meaning that the machine will not run optimally.",
> +   "label": "KlogAcpiCstCount"
> +  },
> +  {
> +   "compare_mode": "string",
>     "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_ACPI_EVAL",
>     "pattern": "No return object",
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - Nov. 21, 2012, 2:54 a.m.
On 11/03/2012 01:15 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add checking for errors produced by ACPI processor_idle
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json |   16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 6a5a831..b91bcbe 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -78,6 +78,22 @@
>    [
>     {
>      "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_CRITICAL",
> +   "tag": "FWTS_ACPI_EVAL",
> +   "pattern": "ACPI: not enough elements in _CST",
> +   "advice": "_CST returned either a NULL buffer or a type that wasn't an ACPI package or less than 2 elements in the package. The kernel could not evaluate the CPU supported C states supported, meaning that the machine will not run optimally.",
> +   "label": "KlogAcpiCstElements"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_CRITICAL",
> +   "tag": "FWTS_ACPI_EVAL",
> +   "pattern": "ACPI: count given by _CST is not valid",
> +   "advice": "_CST returned an invalid number of elements, the package a different number of C states to the number of C states that _CST reported. The kernel could not evaluate the CPU supported C states supported, meaning that the machine will not run optimally.",
> +   "label": "KlogAcpiCstCount"
> +  },
> +  {
> +   "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_ACPI_EVAL",
>      "pattern": "No return object",
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index 6a5a831..b91bcbe 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -78,6 +78,22 @@ 
  [
   {
    "compare_mode": "string",
+   "log_level": "LOG_LEVEL_CRITICAL",
+   "tag": "FWTS_ACPI_EVAL",
+   "pattern": "ACPI: not enough elements in _CST",
+   "advice": "_CST returned either a NULL buffer or a type that wasn't an ACPI package or less than 2 elements in the package. The kernel could not evaluate the CPU supported C states supported, meaning that the machine will not run optimally.",
+   "label": "KlogAcpiCstElements"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_CRITICAL",
+   "tag": "FWTS_ACPI_EVAL",
+   "pattern": "ACPI: count given by _CST is not valid",
+   "advice": "_CST returned an invalid number of elements, the package a different number of C states to the number of C states that _CST reported. The kernel could not evaluate the CPU supported C states supported, meaning that the machine will not run optimally.",
+   "label": "KlogAcpiCstCount"
+  },
+  {
+   "compare_mode": "string",
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_ACPI_EVAL",
    "pattern": "No return object",