Patchwork [03/22] data: klog.json: Add support for the ACPI utils kernel error messages

login
register
mail settings
Submitter Colin King
Date Nov. 2, 2012, 5:15 p.m.
Message ID <1351876532-21869-4-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/196608/
State Accepted
Headers show

Comments

Colin King - Nov. 2, 2012, 5:15 p.m.
From: Colin Ian King <colin.king@canonical.com>

Add checking for errors produced by ACPI utils.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |   32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
Keng-Yu Lin - Nov. 7, 2012, 4:15 a.m.
On Sat, Nov 3, 2012 at 1:15 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add checking for errors produced by ACPI utils.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json |   32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 741739d..6a5a831 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -79,6 +79,38 @@
>    {
>     "compare_mode": "string",
>     "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_EVAL",
> +   "pattern": "No return object",
> +   "advice": "An ACPI evaluate for a reference returned a buffer of zero length or a NULL buffer pointer.",
> +   "label": "KlogAcpiEvalReferenceBadBuffer"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_EVAL",
> +   "pattern": "Expecting a [Package], found type",
> +   "advice": "An ACPI evaluate for a reference did not return a ACPI package as expected.",
> +   "label": "KlogAcpiEvalReferenceNotPackage"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_EVAL",
> +   "pattern": "[Package] has zero elements",
> +   "advice": "An ACPI evaluate for a reference returned an illeage package of zero elements.",
> +   "label": "KlogAcpiEvalReferencePackageZeroElements"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_EVAL",
> +   "pattern": "Expecting a [Reference] package element, found type",
> +   "advice": "An ACPI evaluate for a reference returned contained an element that was not a reference type.",
> +   "label": "KlogAcpiEvalReferencePackageElementType"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_EMBEDDED_CONTROLLER",
>     "pattern": "error obtaining _EC",
>     "advice": "The ACPI Embedded Controller Offset Query Control Method _EC failed to evaluate. It is either missing or broken and means the kernel cound not add a SMBUS host controller.",
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - Nov. 21, 2012, 2:54 a.m.
On 11/03/2012 01:15 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add checking for errors produced by ACPI utils.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json |   32 ++++++++++++++++++++++++++++++++
>   1 file changed, 32 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 741739d..6a5a831 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -79,6 +79,38 @@
>     {
>      "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_EVAL",
> +   "pattern": "No return object",
> +   "advice": "An ACPI evaluate for a reference returned a buffer of zero length or a NULL buffer pointer.",
> +   "label": "KlogAcpiEvalReferenceBadBuffer"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_EVAL",
> +   "pattern": "Expecting a [Package], found type",
> +   "advice": "An ACPI evaluate for a reference did not return a ACPI package as expected.",
> +   "label": "KlogAcpiEvalReferenceNotPackage"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_EVAL",
> +   "pattern": "[Package] has zero elements",
> +   "advice": "An ACPI evaluate for a reference returned an illeage package of zero elements.",
> +   "label": "KlogAcpiEvalReferencePackageZeroElements"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_ACPI_EVAL",
> +   "pattern": "Expecting a [Reference] package element, found type",
> +   "advice": "An ACPI evaluate for a reference returned contained an element that was not a reference type.",
> +   "label": "KlogAcpiEvalReferencePackageElementType"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_EMBEDDED_CONTROLLER",
>      "pattern": "error obtaining _EC",
>      "advice": "The ACPI Embedded Controller Offset Query Control Method _EC failed to evaluate. It is either missing or broken and means the kernel cound not add a SMBUS host controller.",
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index 741739d..6a5a831 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -79,6 +79,38 @@ 
   {
    "compare_mode": "string",
    "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_ACPI_EVAL",
+   "pattern": "No return object",
+   "advice": "An ACPI evaluate for a reference returned a buffer of zero length or a NULL buffer pointer.",
+   "label": "KlogAcpiEvalReferenceBadBuffer"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_ACPI_EVAL",
+   "pattern": "Expecting a [Package], found type",
+   "advice": "An ACPI evaluate for a reference did not return a ACPI package as expected.",
+   "label": "KlogAcpiEvalReferenceNotPackage"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_ACPI_EVAL",
+   "pattern": "[Package] has zero elements",
+   "advice": "An ACPI evaluate for a reference returned an illeage package of zero elements.",
+   "label": "KlogAcpiEvalReferencePackageZeroElements"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_ACPI_EVAL",
+   "pattern": "Expecting a [Reference] package element, found type",
+   "advice": "An ACPI evaluate for a reference returned contained an element that was not a reference type.",
+   "label": "KlogAcpiEvalReferencePackageElementType"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_EMBEDDED_CONTROLLER",
    "pattern": "error obtaining _EC",
    "advice": "The ACPI Embedded Controller Offset Query Control Method _EC failed to evaluate. It is either missing or broken and means the kernel cound not add a SMBUS host controller.",