Patchwork [02/22] data: klog.json: Add support for the ACPI SMBUS driver

login
register
mail settings
Submitter Colin King
Date Nov. 2, 2012, 5:15 p.m.
Message ID <1351876532-21869-3-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/196607/
State Accepted
Headers show

Comments

Colin King - Nov. 2, 2012, 5:15 p.m.
From: Colin Ian King <colin.king@canonical.com>

Add kernel log scanning messages for the ACPI SMBUS driver
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)
Keng-Yu Lin - Nov. 7, 2012, 4:15 a.m.
On Sat, Nov 3, 2012 at 1:15 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add kernel log scanning messages for the ACPI SMBUS driver
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index aa85aa4..741739d 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -79,6 +79,22 @@
>    {
>     "compare_mode": "string",
>     "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_EMBEDDED_CONTROLLER",
> +   "pattern": "error obtaining _EC",
> +   "advice": "The ACPI Embedded Controller Offset Query Control Method _EC failed to evaluate. It is either missing or broken and means the kernel cound not add a SMBUS host controller.",
> +   "label": "KlogAcpiEcFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "host controller is not configured",
> +   "advice": "The kernel count not issue a SMBUS transaction because the host controller was not configured. See acpi_smbus_transaction()",
> +   "label": "KlogSmbusHostController"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI_THERMAL",
>     "pattern": "Invalid _TSS data: freq is zero",
>     "advice": "The _TSS has returned a zero fequency setting in one or more of the package elements.",
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - Nov. 21, 2012, 2:54 a.m.
On 11/03/2012 01:15 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add kernel log scanning messages for the ACPI SMBUS driver
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json |   16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index aa85aa4..741739d 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -79,6 +79,22 @@
>     {
>      "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_EMBEDDED_CONTROLLER",
> +   "pattern": "error obtaining _EC",
> +   "advice": "The ACPI Embedded Controller Offset Query Control Method _EC failed to evaluate. It is either missing or broken and means the kernel cound not add a SMBUS host controller.",
> +   "label": "KlogAcpiEcFailed"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "host controller is not configured",
> +   "advice": "The kernel count not issue a SMBUS transaction because the host controller was not configured. See acpi_smbus_transaction()",
> +   "label": "KlogSmbusHostController"
> +  },
> +  {
> +   "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI_THERMAL",
>      "pattern": "Invalid _TSS data: freq is zero",
>      "advice": "The _TSS has returned a zero fequency setting in one or more of the package elements.",
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index aa85aa4..741739d 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -79,6 +79,22 @@ 
   {
    "compare_mode": "string",
    "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_EMBEDDED_CONTROLLER",
+   "pattern": "error obtaining _EC",
+   "advice": "The ACPI Embedded Controller Offset Query Control Method _EC failed to evaluate. It is either missing or broken and means the kernel cound not add a SMBUS host controller.",
+   "label": "KlogAcpiEcFailed"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "host controller is not configured",
+   "advice": "The kernel count not issue a SMBUS transaction because the host controller was not configured. See acpi_smbus_transaction()",
+   "label": "KlogSmbusHostController"
+  },
+  {
+   "compare_mode": "string",
+   "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI_THERMAL",
    "pattern": "Invalid _TSS data: freq is zero",
    "advice": "The _TSS has returned a zero fequency setting in one or more of the package elements.",