From patchwork Fri Nov 2 07:46:27 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 196502 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3BE3C2C00F3 for ; Fri, 2 Nov 2012 18:47:23 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755293Ab2KBHrL (ORCPT ); Fri, 2 Nov 2012 03:47:11 -0400 Received: from mail-da0-f46.google.com ([209.85.210.46]:34826 "EHLO mail-da0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755403Ab2KBHrF (ORCPT ); Fri, 2 Nov 2012 03:47:05 -0400 Received: by mail-da0-f46.google.com with SMTP id n41so1546198dak.19 for ; Fri, 02 Nov 2012 00:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=22qzPbBxZ3IfOJimZpPevyU+aetv4QluJxI5iGyGO1c=; b=Pzm6Qg1sEyW0zqv+e+TJixPmzG0k03soMFVe2RaIlZX40ejUDpcDkOUXLzEQggfvWy HTWQJnPkdoygE+ntXzKnI3qI3Dg5oL71N6eQtdvBazeISeAY2piAGS0JpGTzsfWFIJ63 HUm749w21gb79vJlNh46Bvf2wFJmoAeAR1QTkvvAdmD4I1tcRCdJOHA5DxpFMe1K9y72 G8Buc2wuPxWdMoTeTWbmdT6xx5Fl3PxsFIb8pUmGZhPQvifL+O9EuruNIBWhmIiMdqLj LSCzSbZCZGyVqW2dvOZ6ldMDsMJgXt20N4ZKX+7DqakySrzZYG0Le8RMStaDBZKUfQog Z2Cw== Received: by 10.68.234.229 with SMTP id uh5mr3589710pbc.123.1351842425024; Fri, 02 Nov 2012 00:47:05 -0700 (PDT) Received: from ld-irv-0074.broadcom.com (pv141010.reshsg.uci.edu. [169.234.141.10]) by mx.google.com with ESMTPS id is6sm5365133pbc.55.2012.11.02.00.47.04 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 02 Nov 2012 00:47:04 -0700 (PDT) From: Brian Norris To: Jeff Garzik Cc: , Brian Norris , Tejun Heo Subject: [PATCH 13/14] pata_octeon_cf: perform host detach, removal on exit Date: Fri, 2 Nov 2012 00:46:27 -0700 Message-Id: <1351842388-27210-14-git-send-email-computersforpeace@gmail.com> X-Mailer: git-send-email 1.7.11.3 In-Reply-To: <1351842388-27210-1-git-send-email-computersforpeace@gmail.com> References: <1351842388-27210-1-git-send-email-computersforpeace@gmail.com> Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org This driver does not detach and remove its ata_host properly on device removal. Add the common .remove helper. Note: I do not know this driver well enough to ensure this is the right thing to do. Merge this patch with caution. Signed-off-by: Brian Norris --- drivers/ata/pata_octeon_cf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c index 1d61d5d..d8df93b 100644 --- a/drivers/ata/pata_octeon_cf.c +++ b/drivers/ata/pata_octeon_cf.c @@ -921,6 +921,7 @@ free_cf_port: static struct platform_driver octeon_cf_driver = { .probe = octeon_cf_probe, + .remove = ata_platform_remove_one, .driver = { .name = DRV_NAME, .owner = THIS_MODULE,