Patchwork [13/14] pata_octeon_cf: perform host detach, removal on exit

login
register
mail settings
Submitter Brian Norris
Date Nov. 2, 2012, 7:46 a.m.
Message ID <1351842388-27210-14-git-send-email-computersforpeace@gmail.com>
Download mbox | patch
Permalink /patch/196502/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Brian Norris - Nov. 2, 2012, 7:46 a.m.
This driver does not detach and remove its ata_host properly on device
removal. Add the common .remove helper.

Note: I do not know this driver well enough to ensure this is the right
thing to do. Merge this patch with caution.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
 drivers/ata/pata_octeon_cf.c | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c
index 1d61d5d..d8df93b 100644
--- a/drivers/ata/pata_octeon_cf.c
+++ b/drivers/ata/pata_octeon_cf.c
@@ -921,6 +921,7 @@  free_cf_port:
 
 static struct platform_driver octeon_cf_driver = {
 	.probe		= octeon_cf_probe,
+	.remove		= ata_platform_remove_one,
 	.driver		= {
 		.name	= DRV_NAME,
 		.owner	= THIS_MODULE,