| Submitter | Stefan Weil |
|---|---|
| Date | Nov. 2, 2012, 7:35 a.m. |
| Message ID | <1351841754-26483-1-git-send-email-sw@weilnetz.de> |
| Download | mbox | patch |
| Permalink | /patch/196491/ |
| State | Accepted |
| Headers | show |
Comments
Am 02.11.2012 08:35, schrieb Stefan Weil: > Replace also "write into" by "write to". > > Signed-off-by: Stefan Weil<sw@weilnetz.de> > --- > > I think "write to" is better, but I am not sure about this, > so please wait until a native speaker has reviewed that patch. > > Regards > Stefan Weil > > hw/s390x/sclp.h | 4 ++-- > hw/s390x/sclpconsole.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/s390x/sclp.h b/hw/s390x/sclp.h > index fe89dad..231a38a 100644 > --- a/hw/s390x/sclp.h > +++ b/hw/s390x/sclp.h > @@ -51,7 +51,7 @@ > > /* > * Normally packed structures are not the right thing to do, since all code > - * must take care of endianess. We cant use ldl_phys and friends for two > + * must take care of endianness. We cannot use ldl_phys and friends for two > * reasons, though: > * - some of the embedded structures below the SCCB can appear multiple times > * at different locations, so there is no fixed offset > @@ -60,7 +60,7 @@ > * alter the structure while we parse it. We cannot use ldl_p and friends > * either without doing pointer arithmetics > * So we have to double check that all users of sclp data structures use the > - * right endianess wrappers. > + * right endianness wrappers. > */ > typedef struct SCCBHeader { > uint16_t length; > diff --git a/hw/s390x/sclpconsole.c b/hw/s390x/sclpconsole.c > index 0ec5623..fece878 100644 > --- a/hw/s390x/sclpconsole.c > +++ b/hw/s390x/sclpconsole.c > @@ -179,8 +179,8 @@ static int read_event_data(SCLPEvent *event, EventBufferHeader *evt_buf_hdr, > } > > /* triggered by SCLP's write_event_data > - * - write console data into character layer > - * returns< 0 if an error occured > + * - write console data to character layer > + * returns< 0 if an error occurred > */ > static ssize_t write_console_data(SCLPEvent *event, const uint8_t *buf, > size_t len) > ping?
On Fri, Nov 02, 2012 at 08:35:54AM +0100, Stefan Weil wrote: > Replace also "write into" by "write to". > > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > > I think "write to" is better, but I am not sure about this, > so please wait until a native speaker has reviewed that patch. "write to" is better. Applied to the trivial patches tree. There is a pending pull request - this patch will be in the next pull request. Stefan
Patch
diff --git a/hw/s390x/sclp.h b/hw/s390x/sclp.h index fe89dad..231a38a 100644 --- a/hw/s390x/sclp.h +++ b/hw/s390x/sclp.h @@ -51,7 +51,7 @@ /* * Normally packed structures are not the right thing to do, since all code - * must take care of endianess. We cant use ldl_phys and friends for two + * must take care of endianness. We cannot use ldl_phys and friends for two * reasons, though: * - some of the embedded structures below the SCCB can appear multiple times * at different locations, so there is no fixed offset @@ -60,7 +60,7 @@ * alter the structure while we parse it. We cannot use ldl_p and friends * either without doing pointer arithmetics * So we have to double check that all users of sclp data structures use the - * right endianess wrappers. + * right endianness wrappers. */ typedef struct SCCBHeader { uint16_t length; diff --git a/hw/s390x/sclpconsole.c b/hw/s390x/sclpconsole.c index 0ec5623..fece878 100644 --- a/hw/s390x/sclpconsole.c +++ b/hw/s390x/sclpconsole.c @@ -179,8 +179,8 @@ static int read_event_data(SCLPEvent *event, EventBufferHeader *evt_buf_hdr, } /* triggered by SCLP's write_event_data - * - write console data into character layer - * returns < 0 if an error occured + * - write console data to character layer + * returns < 0 if an error occurred */ static ssize_t write_console_data(SCLPEvent *event, const uint8_t *buf, size_t len)
Replace also "write into" by "write to". Signed-off-by: Stefan Weil <sw@weilnetz.de> --- I think "write to" is better, but I am not sure about this, so please wait until a native speaker has reviewed that patch. Regards Stefan Weil hw/s390x/sclp.h | 4 ++-- hw/s390x/sclpconsole.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)