| Submitter | Sergei Shtylyov |
|---|---|
| Date | Nov. 1, 2012, 5:59 p.m. |
| Message ID | <201211012059.29109.sshtylyov@ru.mvista.com> |
| Download | mbox | patch |
| Permalink | /patch/196297/ |
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
Comments
Hello. On 11/01/2012 08:59 PM, Sergei Shtylyov wrote: > ahci_highbank_hardreset() uses bare number for the BSY bit of the ATA status > register, despite it is #define'd in <linux/ata.h> > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> > --- > The patch is atop of the 'upstream' branch of libata-dev.git... > drivers/ata/sata_highbank.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Index: libata-dev/drivers/ata/sata_highbank.c > =================================================================== > --- libata-dev.orig/drivers/ata/sata_highbank.c > +++ libata-dev/drivers/ata/sata_highbank.c > @@ -213,7 +213,7 @@ static int ahci_highbank_hardreset(struc > > /* clear D2H reception area to properly wait for D2H FIS */ > ata_tf_init(link->device, &tf); > - tf.command = 0x80; > + tf.command = ATA_BUSY; > ata_tf_to_fis(&tf, 0, 0, d2h_fis); > > do { Jeff, are you going to queue this one and earlier patches from me? MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/21/2012 02:35 PM, Sergei Shtylyov wrote: > Hello. > > On 11/01/2012 08:59 PM, Sergei Shtylyov wrote: > >> ahci_highbank_hardreset() uses bare number for the BSY bit of the ATA status >> register, despite it is #define'd in <linux/ata.h> > >> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> > >> --- >> The patch is atop of the 'upstream' branch of libata-dev.git... > >> drivers/ata/sata_highbank.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> Index: libata-dev/drivers/ata/sata_highbank.c >> =================================================================== >> --- libata-dev.orig/drivers/ata/sata_highbank.c >> +++ libata-dev/drivers/ata/sata_highbank.c >> @@ -213,7 +213,7 @@ static int ahci_highbank_hardreset(struc >> >> /* clear D2H reception area to properly wait for D2H FIS */ >> ata_tf_init(link->device, &tf); >> - tf.command = 0x80; >> + tf.command = ATA_BUSY; >> ata_tf_to_fis(&tf, 0, 0, d2h_fis); >> >> do { > > Jeff, are you going to queue this one and earlier patches from me? Yep, should be queued in next 24-48 hours with a bunch of other stuff. Wanted to get #upstream-fixes upstream and settled first. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/01/2012 01:59 PM, Sergei Shtylyov wrote: > ahci_highbank_hardreset() uses bare number for the BSY bit of the ATA status > register, despite it is #define'd in <linux/ata.h> > > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> > > --- > The patch is atop of the 'upstream' branch of libata-dev.git... > > drivers/ata/sata_highbank.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
Index: libata-dev/drivers/ata/sata_highbank.c =================================================================== --- libata-dev.orig/drivers/ata/sata_highbank.c +++ libata-dev/drivers/ata/sata_highbank.c @@ -213,7 +213,7 @@ static int ahci_highbank_hardreset(struc /* clear D2H reception area to properly wait for D2H FIS */ ata_tf_init(link->device, &tf); - tf.command = 0x80; + tf.command = ATA_BUSY; ata_tf_to_fis(&tf, 0, 0, d2h_fis); do {
ahci_highbank_hardreset() uses bare number for the BSY bit of the ATA status register, despite it is #define'd in <linux/ata.h> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> --- The patch is atop of the 'upstream' branch of libata-dev.git... drivers/ata/sata_highbank.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html