Patchwork GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

login
register
mail settings
Submitter Sharad Singhai
Date Nov. 1, 2012, 4:40 p.m.
Message ID <CAKxPW66URC0PEV6C216H3DTc9E33FY+VQW8utgB7ecDNFcRmFA@mail.gmail.com>
Download mbox | patch
Permalink /patch/196280/
State New
Headers show

Comments

Sharad Singhai - Nov. 1, 2012, 4:40 p.m.
I found the problem and the following patch fixes it. The issue with
my testing was that I was only looking at 'FAIL' lines but forgot to
tally the 'UNRESOLVED' test cases, the real symptoms of my test
problems.  In any case,  I am rerunning the whole testsuite just to be
sure.

Assuming tests pass, is it okay to commit the following?

Thanks,
Sharad

2012-11-01  Sharad Singhai  <singhai@google.com>

PR other/55164
* dumpfile.h (struct dump_file_info): Fix order of flags.
Diego Novillo - Nov. 1, 2012, 4:44 p.m.
On Thu, Nov 1, 2012 at 12:40 PM, Sharad Singhai <singhai@google.com> wrote:
> I found the problem and the following patch fixes it. The issue with
> my testing was that I was only looking at 'FAIL' lines but forgot to
> tally the 'UNRESOLVED' test cases, the real symptoms of my test
> problems.  In any case,  I am rerunning the whole testsuite just to be
> sure.
>
> Assuming tests pass, is it okay to commit the following?
>
> Thanks,
> Sharad
>
> 2012-11-01  Sharad Singhai  <singhai@google.com>
>
> PR other/55164
> * dumpfile.h (struct dump_file_info): Fix order of flags.

OK (remember to insert a tab at the start of each ChangeLog line).


Diego.
Sharad Singhai - Nov. 1, 2012, 5:58 p.m.
On Thu, Nov 1, 2012 at 9:44 AM, Diego Novillo <dnovillo@google.com> wrote:
> On Thu, Nov 1, 2012 at 12:40 PM, Sharad Singhai <singhai@google.com> wrote:
>> I found the problem and the following patch fixes it. The issue with
>> my testing was that I was only looking at 'FAIL' lines but forgot to
>> tally the 'UNRESOLVED' test cases, the real symptoms of my test
>> problems.  In any case,  I am rerunning the whole testsuite just to be
>> sure.
>>
>> Assuming tests pass, is it okay to commit the following?
>>
>> Thanks,
>> Sharad
>>
>> 2012-11-01  Sharad Singhai  <singhai@google.com>
>>
>> PR other/55164
>> * dumpfile.h (struct dump_file_info): Fix order of flags.
>
> OK (remember to insert a tab at the start of each ChangeLog line).

Fixed tab chars. (they were really there, but gmail ate them! :))

Retested and found all my 'UNRESOLVED' problems were gone. Hence
committed the fix as r193064.

Thanks,
Sharad

>
> Diego.
Sterling Augustine - Nov. 1, 2012, 6:02 p.m.
Hi Jakub,

I would like to get the fission implementation in before stage 1. It
has been under review for some time, and is awaiting another round of
review now.

More info here:

http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02684.html

Sterling

Patch

Index: dumpfile.h
===================================================================
--- dumpfile.h (revision 193061)
+++ dumpfile.h (working copy)
@@ -113,8 +113,8 @@  struct dump_file_info
   const char *alt_filename;     /* filename for the -fopt-info stream  */
   FILE *pstream;                /* pass-specific dump stream  */
   FILE *alt_stream;             /* -fopt-info stream */
+  int pflags;                   /* dump flags */
   int optgroup_flags;           /* optgroup flags for -fopt-info */
-  int pflags;                   /* dump flags */
   int alt_flags;                /* flags for opt-info */
   int pstate;                   /* state of pass-specific stream */
   int alt_state;                /* state of the -fopt-info stream */