From patchwork Thu Nov 1 15:28:36 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v2] pata_arasan_cf: declare/use more local variables in arasan_cf_dma_start() Date: Thu, 01 Nov 2012 05:28:36 -0000 From: Sergei Shtylyov X-Patchwork-Id: 196227 Message-Id: <201211011828.36550.sshtylyov@ru.mvista.com> To: linux-ide@vger.kernel.org, jgarzik@pobox.com, viresh.linux@gmail.com 'acdev->qc', 'acdev->qc->ap', and 'acdev->qc->tf' expressions are used multiple times in this function, so it makes sense to use the local variables for them. Signed-off-by: Sergei Shtylyov Acked-by: Viresh Kumar --- The patch is atop of the 'upstream' branch of libata-dev.git... drivers/ata/pata_arasan_cf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: libata-dev/drivers/ata/pata_arasan_cf.c =================================================================== --- libata-dev.orig/drivers/ata/pata_arasan_cf.c +++ libata-dev/drivers/ata/pata_arasan_cf.c @@ -668,13 +668,16 @@ void arasan_cf_error_handler(struct ata_ static void arasan_cf_dma_start(struct arasan_cf_dev *acdev) { + struct ata_queued_cmd *qc = acdev->qc; + struct ata_port *ap = qc->ap; + struct ata_taskfile *tf = &qc->tf; u32 xfer_ctr = readl(acdev->vbase + XFER_CTR) & ~XFER_DIR_MASK; - u32 write = acdev->qc->tf.flags & ATA_TFLAG_WRITE; + u32 write = tf->flags & ATA_TFLAG_WRITE; xfer_ctr |= write ? XFER_WRITE : XFER_READ; writel(xfer_ctr, acdev->vbase + XFER_CTR); - acdev->qc->ap->ops->sff_exec_command(acdev->qc->ap, &acdev->qc->tf); + ap->ops->sff_exec_command(ap, tf); ata_sff_queue_work(&acdev->work); }