Patchwork Silence inline_call sanity check for now

login
register
mail settings
Submitter Jan Hubicka
Date Nov. 1, 2012, 12:42 p.m.
Message ID <20121101124227.GA12720@kam.mff.cuni.cz>
Download mbox | patch
Permalink /patch/196185/
State New
Headers show

Comments

Jan Hubicka - Nov. 1, 2012, 12:42 p.m.
Hi,
this check I added into inline_call last week has cought among other
interesting bugs an an ipa-cp/ipa-prop issue that Martin will fix only later
this or next week (tracked as PR55078).

I am disabling the sanity check for time being because it also triggers with
-O3 bootstrap on some configurations that is not good.

Comitted as obvoius.
Honza

	* ipa-inline-transform.c (inline_call): Silence sanity check until ipa-cp
	issue is fixed.

Patch

Index: ipa-inline-transform.c
===================================================================
--- ipa-inline-transform.c	(revision 192989)
+++ ipa-inline-transform.c	(working copy)
@@ -211,7 +211,8 @@  inline_call (struct cgraph_edge *e, bool
   struct cgraph_node *callee = cgraph_function_or_thunk_node (e->callee, NULL);
   bool new_edges_found = false;
 
-#ifdef ENABLE_CHECKING
+  /* FIXME: re-enable once ipa-cp problem is fixed.  */
+#if 0
   int estimated_growth = estimate_edge_growth (e);
   bool predicated = inline_edge_summary (e)->predicate != NULL;
 #endif
@@ -259,7 +260,8 @@  inline_call (struct cgraph_edge *e, bool
   if (update_overall_summary)
    inline_update_overall_summary (to);
   new_size = inline_summary (to)->size;
-#ifdef ENABLE_CHECKING
+  /* FIXME: re-enable once ipa-cp problem is fixed.  */
+#if 0
   /* Verify that estimated growth match real growth.  Allow off-by-one
      error due to INLINE_SIZE_SCALE roudoff errors.  */
   gcc_assert (!update_overall_summary || !overall_size