Patchwork [5/5] pseries: Cleanup duplications of ics_valid_irq() code

login
register
mail settings
Submitter Alexander Graf
Date Nov. 1, 2012, 12:07 p.m.
Message ID <1351771637-20685-6-git-send-email-agraf@suse.de>
Download mbox | patch
Permalink /patch/196183/
State New
Headers show

Comments

Alexander Graf - Nov. 1, 2012, 12:07 p.m.
From: David Gibson <david@gibson.dropbear.id.au>

A couple of places in xics.c open-coded the same logic as is already
implemented in ics_valid_irq().  This patch fixes the code duplication.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 hw/xics.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

Patch

diff --git a/hw/xics.c b/hw/xics.c
index 7a899dd..ff4b5e2 100644
--- a/hw/xics.c
+++ b/hw/xics.c
@@ -326,8 +326,7 @@  static void ics_eoi(struct ics_state *ics, int nr)
 
 qemu_irq xics_get_qirq(struct icp_state *icp, int irq)
 {
-    if ((irq < icp->ics->offset)
-        || (irq >= (icp->ics->offset + icp->ics->nr_irqs))) {
+    if (!ics_valid_irq(icp->ics, irq)) {
         return NULL;
     }
 
@@ -336,8 +335,7 @@  qemu_irq xics_get_qirq(struct icp_state *icp, int irq)
 
 void xics_set_irq_type(struct icp_state *icp, int irq, bool lsi)
 {
-    assert((irq >= icp->ics->offset)
-           && (irq < (icp->ics->offset + icp->ics->nr_irqs)));
+    assert(ics_valid_irq(icp->ics, irq));
 
     icp->ics->irqs[irq - icp->ics->offset].lsi = lsi;
 }