From patchwork Thu Nov 1 09:12:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Wang X-Patchwork-Id: 196097 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B7BA12C0290 for ; Thu, 1 Nov 2012 20:13:26 +1100 (EST) Received: from localhost ([::1]:48617 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTqq2-0007dr-ET for incoming@patchwork.ozlabs.org; Thu, 01 Nov 2012 05:13:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTqpf-0007B5-P4 for qemu-devel@nongnu.org; Thu, 01 Nov 2012 05:13:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TTqpZ-0000Xk-J1 for qemu-devel@nongnu.org; Thu, 01 Nov 2012 05:12:55 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:47759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTqpZ-0000XR-Cu for qemu-devel@nongnu.org; Thu, 01 Nov 2012 05:12:53 -0400 Received: by mail-pa0-f45.google.com with SMTP id fb10so1545097pad.4 for ; Thu, 01 Nov 2012 02:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=nu4oqvk3zkO3xrJesEPb9XjsRlF+kPNa3bLeHoiiL+k=; b=ajZRmARtI0NFW8uPjgzdRu7Ivore5I/UoItFsH+RGeuv5bvQZF4WXNfII457D+zlrT SBRoagxGUbj0EkYQn0oLIp4Gi+eG3ola9Z4uq93zV0jI+F3cIG4Loe5ya9FpTLTdbLhn Aw96cOBMmQxxtZ+y1t99RUmYzsDtE+HU+fYH9wcLUGOQN6HYXqU55OQ5PVPMqQ6up/iZ cO/ZA6ZGfe9welFXom+IwD7UenXwGW/a87+k5cGmViBb3IBwnnbSiA2xXbJ6e0CUorG8 I3f/EOQqobsBfnw11nio4wcJycvh2Pncusp3qYD1q0LWMB/aqA8t+8Nvyijwb/J9ULkC 5CJw== Received: by 10.66.72.36 with SMTP id a4mr109780034pav.16.1351761171930; Thu, 01 Nov 2012 02:12:51 -0700 (PDT) Received: from localhost.localdomain ([202.108.130.138]) by mx.google.com with ESMTPS id o11sm3751238pby.8.2012.11.01.02.12.49 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 01 Nov 2012 02:12:51 -0700 (PDT) From: Dong Xu Wang To: qemu-devel@nongnu.org Date: Thu, 1 Nov 2012 17:12:23 +0800 Message-Id: <1351761150-20705-4-git-send-email-wdongxu@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1351761150-20705-1-git-send-email-wdongxu@linux.vnet.ibm.com> References: <1351761150-20705-1-git-send-email-wdongxu@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.220.45 Cc: kwolf@redhat.com, Dong Xu Wang Subject: [Qemu-devel] [PATCH V5 03/10] qemu-option: qemu_opt_set_bool(): fix code duplication X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org It will set opt->str in qemu_opt_set_bool, without opt->str, there will be some potential bugs. These are uses of opt->str, and what happens when it isn't set: * qemu_opt_get(): returns NULL, which means "not set". Bug can bite when value isn't the default value. * qemu_opt_parse(): passes NULL to parse_option_bool(), which treats it like "on". Wrong if the value is actually false. Bug can bite when qemu_opts_validate() runs after qemu_opt_set_bool(). * qemu_opt_del(): passes NULL to g_free(), which is just fine. * qemu_opt_foreach(): passes NULL to the callback, which is unlikely to be prepared for it. * qemu_opts_print(): prints NULL, which crashes on some systems. * qemu_opts_to_qdict(): passes NULL to qstring_from_str(), which crashes. It also makes qemu_opt_set_bool more readable by using find_desc_by_name and opts_accepts_any. It is based on Luiz's patch and uses Markus's comments. Discussions can be found at: http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html Signed-off-by: Dong Xu Wang --- qemu-option.c | 27 +++++++++------------------ 1 files changed, 9 insertions(+), 18 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 74321bb..e0131ce 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -677,30 +677,21 @@ int qemu_opt_set_bool(QemuOpts *opts, const char *name, bool val) { QemuOpt *opt; const QemuOptDesc *desc = opts->list->desc; - int i; - for (i = 0; desc[i].name != NULL; i++) { - if (strcmp(desc[i].name, name) == 0) { - break; - } - } - if (desc[i].name == NULL) { - if (i == 0) { - /* empty list -> allow any */; - } else { - qerror_report(QERR_INVALID_PARAMETER, name); - return -1; - } + opt = g_malloc0(sizeof(*opt)); + opt->desc = find_desc_by_name(desc, name); + if (!opt->desc && !opts_accepts_any(opts)) { + qerror_report(QERR_INVALID_PARAMETER, name); + g_free(opt); + return -1; } - opt = g_malloc0(sizeof(*opt)); opt->name = g_strdup(name); opt->opts = opts; - QTAILQ_INSERT_TAIL(&opts->head, opt, next); - if (desc[i].name != NULL) { - opt->desc = desc+i; - } opt->value.boolean = !!val; + opt->str = g_strdup(val ? "on" : "off"); + QTAILQ_INSERT_TAIL(&opts->head, opt, next); + return 0; }