From patchwork Wed Oct 31 15:34:35 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 195987 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0867D2C01E6 for ; Thu, 1 Nov 2012 05:52:07 +1100 (EST) Received: from localhost ([::1]:56922 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTdOX-0000Mx-O7 for incoming@patchwork.ozlabs.org; Wed, 31 Oct 2012 14:52:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTdOR-0000Mp-9N for qemu-devel@nongnu.org; Wed, 31 Oct 2012 14:52:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TTdON-00079c-Cf for qemu-devel@nongnu.org; Wed, 31 Oct 2012 14:51:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTdON-00078p-4L for qemu-devel@nongnu.org; Wed, 31 Oct 2012 14:51:55 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9VIprNK007044 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 31 Oct 2012 14:51:53 -0400 Received: from localhost (ovpn-112-25.ams2.redhat.com [10.36.112.25]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9VIpqRL013705; Wed, 31 Oct 2012 14:51:52 -0400 From: Stefan Hajnoczi To: Date: Wed, 31 Oct 2012 16:34:35 +0100 Message-Id: <1351697677-31598-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1351697677-31598-1-git-send-email-stefanha@redhat.com> References: <1351697677-31598-1-git-send-email-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Kevin Wolf , Paolo Bonzini , Anthony Liguori , Stefan Hajnoczi Subject: [Qemu-devel] [PATCH v2 1/3] aio: switch aiocb_size type int -> size_t X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Using appropriate types for variables is a good thing :). All users simply do sizeof(MyType) and the value is passed to a memory allocator, it should be size_t. Signed-off-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini --- qemu-aio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-aio.h b/qemu-aio.h index 1b7eb6e..111b0b3 100644 --- a/qemu-aio.h +++ b/qemu-aio.h @@ -23,7 +23,7 @@ typedef void BlockDriverCompletionFunc(void *opaque, int ret); typedef struct AIOPool { void (*cancel)(BlockDriverAIOCB *acb); - int aiocb_size; + size_t aiocb_size; BlockDriverAIOCB *free_aiocb; } AIOPool;