Patchwork [1/4] lib: include: fwts_log, add in new label field

login
register
mail settings
Submitter Colin King
Date Oct. 31, 2012, 2:11 p.m.
Message ID <1351692684-15611-2-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/195881/
State Accepted
Headers show

Comments

Colin King - Oct. 31, 2012, 2:11 p.m.
From: Colin Ian King <colin.king@canonical.com>

We need to keep track of the labels per error message rather than
rely on automatically generating these at run time.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/include/fwts_klog.h |    1 +
 1 file changed, 1 insertion(+)
Alex Hung - Nov. 5, 2012, 9:29 a.m.
On 10/31/2012 10:11 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> We need to keep track of the labels per error message rather than
> rely on automatically generating these at run time.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/lib/include/fwts_klog.h |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/lib/include/fwts_klog.h b/src/lib/include/fwts_klog.h
> index a47cf7a..db3b65b 100644
> --- a/src/lib/include/fwts_klog.h
> +++ b/src/lib/include/fwts_klog.h
> @@ -43,6 +43,7 @@ typedef struct {
>   	fwts_tag tag;
>           const char *pattern;
>   	const char *advice;
> +	char *label;
>   	pcre *re;
>   	pcre_extra *extra;
>   } fwts_klog_pattern;
>

Acked-by: Alex Hung <alex.hung@canonical.com>
Keng-Yu Lin - Nov. 6, 2012, 6:31 a.m.
On Wed, Oct 31, 2012 at 10:11 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> We need to keep track of the labels per error message rather than
> rely on automatically generating these at run time.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/include/fwts_klog.h |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/lib/include/fwts_klog.h b/src/lib/include/fwts_klog.h
> index a47cf7a..db3b65b 100644
> --- a/src/lib/include/fwts_klog.h
> +++ b/src/lib/include/fwts_klog.h
> @@ -43,6 +43,7 @@ typedef struct {
>         fwts_tag tag;
>          const char *pattern;
>         const char *advice;
> +       char *label;
>         pcre *re;
>         pcre_extra *extra;
>  } fwts_klog_pattern;
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/src/lib/include/fwts_klog.h b/src/lib/include/fwts_klog.h
index a47cf7a..db3b65b 100644
--- a/src/lib/include/fwts_klog.h
+++ b/src/lib/include/fwts_klog.h
@@ -43,6 +43,7 @@  typedef struct {
 	fwts_tag tag;
         const char *pattern;
 	const char *advice;
+	char *label;
 	pcre *re;
 	pcre_extra *extra;
 } fwts_klog_pattern;