Patchwork [6/8] usb-redir: Use reject rather the disconnect on bad ep info

login
register
mail settings
Submitter Hans de Goede
Date Oct. 31, 2012, 12:47 p.m.
Message ID <1351687636-14253-7-git-send-email-hdegoede@redhat.com>
Download mbox | patch
Permalink /patch/195861/
State New
Headers show

Comments

Hans de Goede - Oct. 31, 2012, 12:47 p.m.
So that the client gets a notification about us disconnecting the device.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 hw/usb/redirect.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Patch

diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index ade5cc6..a3ce815 100644
--- a/hw/usb/redirect.c
+++ b/hw/usb/redirect.c
@@ -1372,7 +1372,8 @@  static void usbredir_ep_info(void *priv,
         case usb_redir_type_interrupt:
             if (dev->endpoint[i].interval == 0) {
                 ERROR("Received 0 interval for isoc or irq endpoint\n");
-                usbredir_device_disconnect(dev);
+                usbredir_reject_device(dev);
+                return;
             }
             /* Fall through */
         case usb_redir_type_control:
@@ -1382,7 +1383,7 @@  static void usbredir_ep_info(void *priv,
             break;
         default:
             ERROR("Received invalid endpoint type\n");
-            usbredir_device_disconnect(dev);
+            usbredir_reject_device(dev);
             return;
         }
     }