From patchwork Wed Oct 31 11:27:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: JonY X-Patchwork-Id: 195853 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 9B36A2C0081 for ; Wed, 31 Oct 2012 22:28:59 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1352287740; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC: Subject:References:In-Reply-To:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=spVynA5r5WR+Jy/7RXDZlK5Y+Q4=; b=MbmOcGT4TGm1XymeKKdjDAB4MLa8gm0uz7sCEhlU1Vuf0ZPOfMxhYgD+41YBtE s0rrrFb6qdHBUBrKQimSgpeJm/SoXZ/AVgkCR3vkw9P/SJY5Mq0pbO743gTx+uGR 69e2GhWLI2ray/iKWr2pMcwalzIe8/k58eExQGkTtWdcg= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=gBJ9XrRDJRz5h1VBXGMAUBAZvJf3dtW5XhxYdCRk39cMqkHLoQvAv5xOqH6gWr R2/E3rZOb2Mj9+h1Uo7gXCrENm307ws6V8pRE3dLq8s+di5LEiE9lvF+6ld7yDwq ZraHQ0Dngua2nPPJ73Amo/vvXAiOaAiaUXN7CESpLVl8g=; Received: (qmail 17291 invoked by alias); 31 Oct 2012 11:28:49 -0000 Received: (qmail 17270 invoked by uid 22791); 31 Oct 2012 11:28:48 -0000 X-SWARE-Spam-Status: No, hits=-8.7 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, KHOP_PGP_SIGNED, KHOP_RCVD_TRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-pa0-f47.google.com (HELO mail-pa0-f47.google.com) (209.85.220.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 31 Oct 2012 11:27:20 +0000 Received: by mail-pa0-f47.google.com with SMTP id fa11so871393pad.20 for ; Wed, 31 Oct 2012 04:27:20 -0700 (PDT) Received: by 10.68.132.165 with SMTP id ov5mr110181198pbb.105.1351682839961; Wed, 31 Oct 2012 04:27:19 -0700 (PDT) Received: from [175.144.235.97] ([175.144.235.97]) by mx.google.com with ESMTPS id qd9sm2168771pbb.31.2012.10.31.04.27.17 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 31 Oct 2012 04:27:19 -0700 (PDT) Message-ID: <50910B10.2020707@users.sourceforge.net> Date: Wed, 31 Oct 2012 19:27:12 +0800 From: JonY User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12) Gecko/20080213 Thunderbird/2.0.0.12 Mnenhy/0.7.5.0 MIME-Version: 1.0 To: Jonathan Wakely CC: gcc-patches@gcc.gnu.org, libstdc++ , Kai Tietz Subject: Re: [Patch] Remove _GLIBCXX_HAVE_BROKEN_VSWPRINTF from (was Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon) References: <50910A2F.3080102@users.sourceforge.net> In-Reply-To: <50910A2F.3080102@users.sourceforge.net> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 10/31/2012 19:23, JonY wrote: > >> Why is the define commented out by the patch, not simply removed? >> If it's not needed then it's not needed. We have subversion to track >> change history, we don't need to leave dead code lying around with >> comments explaining why it's dead. > > OK, I will remove it. > Sorry, forgot to attach the patch. ChangeLog 2012-10-31 Jonathan Yong * config/os/mingw32-w64/os_defines.h: Remove _GLIBCXX_HAVE_BROKEN_VSWPRINTF as no longer required. Index: libstdc++-v3/config/os/mingw32-w64/os_defines.h =================================================================== --- libstdc++-v3/config/os/mingw32-w64/os_defines.h (revision 192802) +++ libstdc++-v3/config/os/mingw32-w64/os_defines.h (working copy) @@ -63,9 +63,6 @@ // See libstdc++/20806. #define _GLIBCXX_HAVE_DOS_BASED_FILESYSTEM 1 -// See libstdc++/37522. -#define _GLIBCXX_HAVE_BROKEN_VSWPRINTF 1 - // See libstdc++/43738 // On native windows targets there is no ioctl function. And the existing // ioctlsocket function doesn't work for normal file-descriptors.