Patchwork Remove _GLIBCXX_HAVE_BROKEN_VSWPRINTF from (was Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon)

login
register
mail settings
Submitter JonY
Date Oct. 31, 2012, 11:27 a.m.
Message ID <50910B10.2020707@users.sourceforge.net>
Download mbox | patch
Permalink /patch/195853/
State New
Headers show

Comments

JonY - Oct. 31, 2012, 11:27 a.m.
On 10/31/2012 19:23, JonY wrote:
> 
>> Why is the define commented out by the patch, not simply removed?
>> If it's not needed then it's not needed. We have subversion to track
>> change history, we don't need to leave dead code lying around with
>> comments explaining why it's dead.
> 
> OK, I will remove it.
> 

Sorry, forgot to attach the patch.

ChangeLog
2012-10-31  Jonathan Yong  <jon_y@users.sourceforge.net>

	* config/os/mingw32-w64/os_defines.h: Remove _GLIBCXX_HAVE_BROKEN_VSWPRINTF
	as no longer required.
Paolo Carlini - Oct. 31, 2012, 11:37 a.m.
Applied.

Thanks,
Paolo.

Patch

Index: libstdc++-v3/config/os/mingw32-w64/os_defines.h
===================================================================
--- libstdc++-v3/config/os/mingw32-w64/os_defines.h	(revision 192802)
+++ libstdc++-v3/config/os/mingw32-w64/os_defines.h	(working copy)
@@ -63,9 +63,6 @@ 
 // See libstdc++/20806.
 #define _GLIBCXX_HAVE_DOS_BASED_FILESYSTEM 1
 
-// See  libstdc++/37522.
-#define _GLIBCXX_HAVE_BROKEN_VSWPRINTF 1
-
 // See libstdc++/43738
 // On native windows targets there is no ioctl function. And the existing
 // ioctlsocket function doesn't work for normal file-descriptors.