Patchwork [25/28] target-i386: make cpu_x86_fill_host() void

login
register
mail settings
Submitter Marcelo Tosatti
Date Oct. 31, 2012, 9:40 a.m.
Message ID <1aefc6b8cbe66e5adb3e6b160f6790171e0a7785.1351676406.git.mtosatti@redhat.com>
Download mbox | patch
Permalink /patch/195834/
State New
Headers show

Comments

Marcelo Tosatti - Oct. 31, 2012, 9:40 a.m.
From: Eduardo Habkost <ehabkost@redhat.com>

The return value of that function is always 0, and is always ignored.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
---
 target-i386/cpu.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

Patch

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 4417d6a..6575834 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -766,7 +766,7 @@  static int cpu_x86_fill_model_id(char *str)
     return 0;
 }
 
-static int cpu_x86_fill_host(x86_def_t *x86_cpu_def)
+static void cpu_x86_fill_host(x86_def_t *x86_cpu_def)
 {
     uint32_t eax = 0, ebx = 0, ecx = 0, edx = 0;
 
@@ -819,8 +819,6 @@  static int cpu_x86_fill_host(x86_def_t *x86_cpu_def)
      * unsupported ones later.
      */
     x86_cpu_def->svm_features = -1;
-
-    return 0;
 }
 
 static int unavailable_host_feature(struct model_features_t *f, uint32_t mask)