From patchwork Wed Oct 31 08:06:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaotian Feng X-Patchwork-Id: 195765 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id C4A402C037C for ; Wed, 31 Oct 2012 19:06:06 +1100 (EST) Received: from mail-da0-f51.google.com (mail-da0-f51.google.com [209.85.210.51]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id F03B82C0106 for ; Wed, 31 Oct 2012 19:05:38 +1100 (EST) Received: by mail-da0-f51.google.com with SMTP id t11so489042daj.38 for ; Wed, 31 Oct 2012 01:05:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=PF+hDAZdLvj8ASL9u0DXf0bVhJ7aWW/k7ZlNo/i98JM=; b=Af6LwRHrgZa4zDnHv0XJsub+fRuIRBkGaOaDhw5OEkNDzz+8rtCP3fALXqatts9XJM njcaTKH1JzE00eDVanJggRfillfbu+Rxon0Zmj1kle1mVOAkUNR2F5hWNU8/ZibsM73o aZLpGDfNV/qOPmR7lENUuoNZWi/kjh56B6yQADYPw/wC82vxGspOAJKugxlQGNHMbMIC g598BjKfZGexDEBRDMRprM71FowkLNVWzV/Ny9ONXpAqEilkQUjnJ8FXxIth1Auu1A2p tdNE3C8Av5D8MsMunsncuvmNA0T6tUJmj/G9VoPrD6ixI5kfzzoun9rNCnLnpFhCwyFn illg== Received: by 10.68.239.198 with SMTP id vu6mr111470968pbc.109.1351670736458; Wed, 31 Oct 2012 01:05:36 -0700 (PDT) Received: from localhost.localdomain ([61.135.172.68]) by mx.google.com with ESMTPS id ju7sm1918850pbb.60.2012.10.31.01.05.26 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 31 Oct 2012 01:05:35 -0700 (PDT) From: Xiaotian Feng To: linux-kernel@vger.kernel.org Subject: [PATCH 2/3] usb: gadget: fsl_qe_udc: do not use tasklet_disable before tasklet_kill Date: Wed, 31 Oct 2012 16:06:00 +0800 Message-Id: <1351670761-26749-2-git-send-email-xtfeng@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1351670761-26749-1-git-send-email-xtfeng@gmail.com> References: <1351670761-26749-1-git-send-email-xtfeng@gmail.com> Cc: Xiaotian Feng , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Felipe Balbi , Xiaotian Feng , linuxppc-dev@lists.ozlabs.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" If tasklet_disable() is called before related tasklet handled, tasklet_kill will never be finished. tasklet_kill is enough. Signed-off-by: Xiaotian Feng Cc: Li Yang Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org --- drivers/usb/gadget/fsl_qe_udc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/gadget/fsl_qe_udc.c b/drivers/usb/gadget/fsl_qe_udc.c index b09452d..4ad3b82 100644 --- a/drivers/usb/gadget/fsl_qe_udc.c +++ b/drivers/usb/gadget/fsl_qe_udc.c @@ -2661,7 +2661,7 @@ static int __devexit qe_udc_remove(struct platform_device *ofdev) usb_del_gadget_udc(&udc->gadget); udc->done = &done; - tasklet_disable(&udc->rx_tasklet); + tasklet_kill(&udc->rx_tasklet); if (udc->nullmap) { dma_unmap_single(udc->gadget.dev.parent, @@ -2698,8 +2698,6 @@ static int __devexit qe_udc_remove(struct platform_device *ofdev) free_irq(udc->usb_irq, udc); irq_dispose_mapping(udc->usb_irq); - tasklet_kill(&udc->rx_tasklet); - iounmap(udc->usb_regs); device_unregister(&udc->gadget.dev);