Patchwork package: add knxweb

login
register
mail settings
Submitter Gregory Hermant
Date Oct. 30, 2012, 12:24 p.m.
Message ID <1351599843-24291-4-git-send-email-gregory.hermant@calao-systems.com>
Download mbox | patch
Permalink /patch/195476/
State Rejected
Headers show

Comments

Gregory Hermant - Oct. 30, 2012, 12:24 p.m.
Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
---
 package/Config.in        |    1 +
 package/knxweb/Config.in |    6 ++++++
 package/knxweb/knxweb.mk |   20 ++++++++++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/knxweb/Config.in
 create mode 100644 package/knxweb/knxweb.mk
Thomas Petazzoni - Oct. 30, 2012, 12:55 p.m.
Dear Gregory Hermant,

On Tue, 30 Oct 2012 13:24:03 +0100, Gregory Hermant wrote:
> diff --git a/package/knxweb/knxweb.mk b/package/knxweb/knxweb.mk
> new file mode 100644
> index 0000000..5ca1760
> --- /dev/null
> +++ b/package/knxweb/knxweb.mk
> @@ -0,0 +1,20 @@
> +#############################################################
> +#
> +# knxweb
> +#
> +#############################################################
> +
> +KNXWEB_VERSION = 0.6.1
> +KNXWEB_SOURCE = knxweb-$(KNXWEB_VERSION).tar.gz
> +KNXWEB_SITE = http://sourceforge.net/projects/linknx/files/knxweb/knxweb-0.6.1/

The tarball has no license information, this is quite annoying.

> +define KNXWEB_INSTALL_TARGET_CMDS
> +	mkdir -p $(TARGET_DIR)/var/www
> +	cp -rdpf $(@D)/* $(TARGET_DIR)/var/www
> +endef
> +
> +define KNXWEB__UNINSTALL_TARGET_CMDS
> +	rm -rf $(TARGET_DIR)/var/www/
> +endef

Double _ here, so this doesn't work.

However, how does this web interface works? I see a few PHP scripts,
but they don't seem to be essential for the operation of the Web
interface. There's a lot of JS though. Does it communicate with the
server somehow?

I'm surprised that no interpreter like PHP, Lua or Python is needed
here for the server side, that's why I'm asking.

Thanks,

Thomas
Gregory Hermant - Nov. 6, 2012, 8:19 a.m.
Hi thomas,

Le 30/10/2012 13:55, Thomas Petazzoni a écrit :
> Dear Gregory Hermant,
> 
> On Tue, 30 Oct 2012 13:24:03 +0100, Gregory Hermant wrote:
>> diff --git a/package/knxweb/knxweb.mk b/package/knxweb/knxweb.mk
>> new file mode 100644
>> index 0000000..5ca1760
>> --- /dev/null
>> +++ b/package/knxweb/knxweb.mk
>> @@ -0,0 +1,20 @@
>> +#############################################################
>> +#
>> +# knxweb
>> +#
>> +#############################################################
>> +
>> +KNXWEB_VERSION = 0.6.1
>> +KNXWEB_SOURCE = knxweb-$(KNXWEB_VERSION).tar.gz
>> +KNXWEB_SITE = http://sourceforge.net/projects/linknx/files/knxweb/knxweb-0.6.1/
> 
> The tarball has no license information, this is quite annoying.

How can we manage this kind of package in buildroot ?
> 
>> +define KNXWEB_INSTALL_TARGET_CMDS
>> +	mkdir -p $(TARGET_DIR)/var/www
>> +	cp -rdpf $(@D)/* $(TARGET_DIR)/var/www
>> +endef
>> +
>> +define KNXWEB__UNINSTALL_TARGET_CMDS
>> +	rm -rf $(TARGET_DIR)/var/www/
>> +endef
> 
> Double _ here, so this doesn't work.
> 
> However, how does this web interface works? I see a few PHP scripts,
> but they don't seem to be essential for the operation of the Web
> interface. There's a lot of JS though. Does it communicate with the
> server somehow?
> 
knxweb needs a web server with PHP support.

> I'm surprised that no interpreter like PHP, Lua or Python is needed
> here for the server side, that's why I'm asking.
> 

> Thanks,
> 
> Thomas
> 

gregory
Arnout Vandecappelle - Nov. 13, 2012, 8:21 p.m.
On 06/11/12 09:19, Grégory Hermant wrote:
> Hi thomas,
>
> Le 30/10/2012 13:55, Thomas Petazzoni a écrit :
>> Dear Gregory Hermant,
>>
>> On Tue, 30 Oct 2012 13:24:03 +0100, Gregory Hermant wrote:
>>> diff --git a/package/knxweb/knxweb.mk b/package/knxweb/knxweb.mk
>>> new file mode 100644
>>> index 0000000..5ca1760
>>> --- /dev/null
>>> +++ b/package/knxweb/knxweb.mk
>>> @@ -0,0 +1,20 @@
>>> +#############################################################
>>> +#
>>> +# knxweb
>>> +#
>>> +#############################################################
>>> +
>>> +KNXWEB_VERSION = 0.6.1
>>> +KNXWEB_SOURCE = knxweb-$(KNXWEB_VERSION).tar.gz
>>> +KNXWEB_SITE = http://sourceforge.net/projects/linknx/files/knxweb/knxweb-0.6.1/

  This URL doesn't work - it should be
http://downloads.sourceforge.net/project/linknx/knxweb/knxweb-0.6

  For this case, you better refactor
KNXWEB_VERSION_MAJOR = 0.6
KNXWEB_VERSION = $(KNXWEB_VERSION_MAJOR).1
KNXWEB_SITE = http://downloads.sourceforge.net/project/linknx/knxweb/knxweb-$(KNXWEB_VERSION_MAJOR)

  Note that you can remove KNXWEB_SOURCE, it is the default.

>>
>> The tarball has no license information, this is quite annoying.
>
> How can we manage this kind of package in buildroot ?

  There's no solution, it's just annoying. Or actually, it's more than annoying:
since no explicit permission is given to copy the code, any use beyond simply
downloading it is illegal... So I guess you should put:

KNXWEB_LICENSE = none (no permission is given)

>>
>>> +define KNXWEB_INSTALL_TARGET_CMDS
>>> +	mkdir -p $(TARGET_DIR)/var/www
>>> +	cp -rdpf $(@D)/* $(TARGET_DIR)/var/www
>>> +endef
>>> +
>>> +define KNXWEB__UNINSTALL_TARGET_CMDS
>>> +	rm -rf $(TARGET_DIR)/var/www/
>>> +endef
>>
>> Double _ here, so this doesn't work.
>>
>> However, how does this web interface works? I see a few PHP scripts,
>> but they don't seem to be essential for the operation of the Web
>> interface. There's a lot of JS though. Does it communicate with the
>> server somehow?
>>
> knxweb needs a web server with PHP support.
>
>> I'm surprised that no interpreter like PHP, Lua or Python is needed
>> here for the server side, that's why I'm asking.

  At the moment we can't select or depend on a web server. Selecting PHP is
possible, however, so I think you should add that to Config.in (not to the
.mk file because there is no build-time dependency)


  Regards,
  Arnout

Patch

diff --git a/package/Config.in b/package/Config.in
index 3dd169f..2a99882 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -579,6 +579,7 @@  source "package/ipset/Config.in"
 source "package/iptables/Config.in"
 source "package/iw/Config.in"
 source "package/kismet/Config.in"
+source "package/knxweb/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/lighttpd/Config.in"
 endif
diff --git a/package/knxweb/Config.in b/package/knxweb/Config.in
new file mode 100644
index 0000000..088e6e1
--- /dev/null
+++ b/package/knxweb/Config.in
@@ -0,0 +1,6 @@ 
+config BR2_PACKAGE_KNXWEB
+	bool "knxweb"
+	help
+	  KnxWeb is a graphical visualization interface for Linknx.
+
+	  http://belnet.dl.sourceforge.net/sourceforge/linknx/
diff --git a/package/knxweb/knxweb.mk b/package/knxweb/knxweb.mk
new file mode 100644
index 0000000..5ca1760
--- /dev/null
+++ b/package/knxweb/knxweb.mk
@@ -0,0 +1,20 @@ 
+#############################################################
+#
+# knxweb
+#
+#############################################################
+
+KNXWEB_VERSION = 0.6.1
+KNXWEB_SOURCE = knxweb-$(KNXWEB_VERSION).tar.gz
+KNXWEB_SITE = http://sourceforge.net/projects/linknx/files/knxweb/knxweb-0.6.1/
+
+define KNXWEB_INSTALL_TARGET_CMDS
+	mkdir -p $(TARGET_DIR)/var/www
+	cp -rdpf $(@D)/* $(TARGET_DIR)/var/www
+endef
+
+define KNXWEB__UNINSTALL_TARGET_CMDS
+	rm -rf $(TARGET_DIR)/var/www/
+endef
+
+$(eval $(generic-package))