Patchwork matchbox-lib: Append -lX11 to the linker

login
register
mail settings
Submitter Markos Chandras
Date Oct. 30, 2012, 11:29 a.m.
Message ID <1351596554-27077-1-git-send-email-markos.chandras@gmail.com>
Download mbox | patch
Permalink /patch/195454/
State Accepted
Commit cc6da8b28ef6b6dde2eaaaf40d21f366508221ad
Headers show

Comments

Markos Chandras - Oct. 30, 2012, 11:29 a.m.
From: Markos Chandras <markos.chandras@imgtec.com>

Fixes building with binutils-2.22
http://autobuild.buildroot.net/results/b4b26dd9c7d7bebe45638ba125fb49a5f5d0cc14/build-end.log

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
 package/matchbox/matchbox-lib/matchbox-lib.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Thomas Petazzoni - Oct. 30, 2012, 1 p.m.
Dear Markos Chandras,

On Tue, 30 Oct 2012 11:29:14 +0000, Markos Chandras wrote:
> From: Markos Chandras <markos.chandras@imgtec.com>
> 
> Fixes building with binutils-2.22
> http://autobuild.buildroot.net/results/b4b26dd9c7d7bebe45638ba125fb49a5f5d0cc14/build-end.log
> 
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
>  package/matchbox/matchbox-lib/matchbox-lib.mk |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/package/matchbox/matchbox-lib/matchbox-lib.mk b/package/matchbox/matchbox-lib/matchbox-lib.mk
> index de11dfc..339f512 100644
> --- a/package/matchbox/matchbox-lib/matchbox-lib.mk
> +++ b/package/matchbox/matchbox-lib/matchbox-lib.mk
> @@ -10,6 +10,7 @@ MATCHBOX_LIB_SITE = http://matchbox-project.org/sources/libmatchbox/$(MATCHBOX_L
>  MATCHBOX_LIB_INSTALL_STAGING = YES
>  MATCHBOX_LIB_DEPENDENCIES = host-pkgconf expat xlib_libXext
>  MATCHBOX_LIB_CONF_OPT = --enable-expat --disable-doxygen-docs
> +MATCHBOX_LIB_CONF_ENV = LIBS="-lX11"

This works but is a hack. Has the problem been fixed in newer upstream
releases? If not, would it be possible to cook a patch to send upstream?

Ditto for the matchbox-desktop patch.

Thanks,

Thomas
Markos Chandras - Oct. 30, 2012, 1:21 p.m.
On Tue, Oct 30, 2012 at 1:00 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Markos Chandras,
>
> On Tue, 30 Oct 2012 11:29:14 +0000, Markos Chandras wrote:
>> From: Markos Chandras <markos.chandras@imgtec.com>
>>
>> Fixes building with binutils-2.22
>> http://autobuild.buildroot.net/results/b4b26dd9c7d7bebe45638ba125fb49a5f5d0cc14/build-end.log
>>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> ---
>>  package/matchbox/matchbox-lib/matchbox-lib.mk |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/package/matchbox/matchbox-lib/matchbox-lib.mk b/package/matchbox/matchbox-lib/matchbox-lib.mk
>> index de11dfc..339f512 100644
>> --- a/package/matchbox/matchbox-lib/matchbox-lib.mk
>> +++ b/package/matchbox/matchbox-lib/matchbox-lib.mk
>> @@ -10,6 +10,7 @@ MATCHBOX_LIB_SITE = http://matchbox-project.org/sources/libmatchbox/$(MATCHBOX_L
>>  MATCHBOX_LIB_INSTALL_STAGING = YES
>>  MATCHBOX_LIB_DEPENDENCIES = host-pkgconf expat xlib_libXext
>>  MATCHBOX_LIB_CONF_OPT = --enable-expat --disable-doxygen-docs
>> +MATCHBOX_LIB_CONF_ENV = LIBS="-lX11"
>
> This works but is a hack. Has the problem been fixed in newer upstream
> releases? If not, would it be possible to cook a patch to send upstream?
>
> Ditto for the matchbox-desktop patch.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com

Hi Thomas,

There is no matchbox upstream. Latest release was in 2007 and the
latest post in the mailing list was in 2007 as well.
Their svn repo seems dead too

http://svn.o-hand.com/view/matchbox/trunk/
Thomas Petazzoni - Oct. 30, 2012, 1:30 p.m.
Dear Markos Chandras,

On Tue, 30 Oct 2012 13:21:22 +0000, Markos Chandras wrote:

> There is no matchbox upstream. Latest release was in 2007 and the
> latest post in the mailing list was in 2007 as well.
> Their svn repo seems dead too
> 
> http://svn.o-hand.com/view/matchbox/trunk/

Hum, right. Do we want to keep those packages in Buildroot then? :-)

Thomas
Markos Chandras - Oct. 30, 2012, 1:53 p.m.
On Tue, Oct 30, 2012 at 1:30 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Markos Chandras,
>
> On Tue, 30 Oct 2012 13:21:22 +0000, Markos Chandras wrote:
>
>> There is no matchbox upstream. Latest release was in 2007 and the
>> latest post in the mailing list was in 2007 as well.
>> Their svn repo seems dead too
>>
>> http://svn.o-hand.com/view/matchbox/trunk/
>
> Hum, right. Do we want to keep those packages in Buildroot then? :-)
>

Well at least they build now :) There are other alternatives of course
(openbox, fluxbox) but I think matchbox
targets different devices (like PDAs or devices with small screens).
My personal opinion is to keep them
around until we reach a point where patching them becomes a non-trivial process.
Markos Chandras - Nov. 19, 2012, 1:23 p.m.
On Tue, Oct 30, 2012 at 1:53 PM, Markos Chandras
<markos.chandras@gmail.com> wrote:
> On Tue, Oct 30, 2012 at 1:30 PM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
>> Dear Markos Chandras,
>>
>> On Tue, 30 Oct 2012 13:21:22 +0000, Markos Chandras wrote:
>>
>>> There is no matchbox upstream. Latest release was in 2007 and the
>>> latest post in the mailing list was in 2007 as well.
>>> Their svn repo seems dead too
>>>
>>> http://svn.o-hand.com/view/matchbox/trunk/
>>
>> Hum, right. Do we want to keep those packages in Buildroot then? :-)
>>
>
> Well at least they build now :) There are other alternatives of course
> (openbox, fluxbox) but I think matchbox
> targets different devices (like PDAs or devices with small screens).
> My personal opinion is to keep them
> around until we reach a point where patching them becomes a non-trivial process.
>
> --
> Regards,
> Markos

Hi,

Ping? :)
Thomas Petazzoni - Nov. 28, 2012, 4:42 p.m.
Peter,

Could you apply this one to 2012.11 ? Thanks!

On Tue, 30 Oct 2012 11:29:14 +0000, Markos Chandras wrote:
> From: Markos Chandras <markos.chandras@imgtec.com>
> 
> Fixes building with binutils-2.22
> http://autobuild.buildroot.net/results/b4b26dd9c7d7bebe45638ba125fb49a5f5d0cc14/build-end.log
> 
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thomas
Peter Korsgaard - Nov. 30, 2012, 7:55 p.m.
>>>>> "Markos" == Markos Chandras <markos.chandras@gmail.com> writes:

 Markos> From: Markos Chandras <markos.chandras@imgtec.com>
 Markos> Fixes building with binutils-2.22
 Markos> http://autobuild.buildroot.net/results/b4b26dd9c7d7bebe45638ba125fb49a5f5d0cc14/build-end.log

Committed, thanks.

Patch

diff --git a/package/matchbox/matchbox-lib/matchbox-lib.mk b/package/matchbox/matchbox-lib/matchbox-lib.mk
index de11dfc..339f512 100644
--- a/package/matchbox/matchbox-lib/matchbox-lib.mk
+++ b/package/matchbox/matchbox-lib/matchbox-lib.mk
@@ -10,6 +10,7 @@  MATCHBOX_LIB_SITE = http://matchbox-project.org/sources/libmatchbox/$(MATCHBOX_L
 MATCHBOX_LIB_INSTALL_STAGING = YES
 MATCHBOX_LIB_DEPENDENCIES = host-pkgconf expat xlib_libXext
 MATCHBOX_LIB_CONF_OPT = --enable-expat --disable-doxygen-docs
+MATCHBOX_LIB_CONF_ENV = LIBS="-lX11"
 
 define MATCHBOX_LIB_POST_INSTALL_FIXES
  $(SED) 's:-I[^$$].*/usr/include/freetype2:-I/usr/include/freetype2:' $(STAGING_DIR)/usr/lib/pkgconfig/libmb.pc