Patchwork dbus: don't quote scan_freq and freq_list

login
register
mail settings
Submitter Robert Shade
Date Oct. 30, 2012, 2:08 a.m.
Message ID <CAMgrJ3b__u0FPYEEvsPogm6J+A2KC3Sw2U5k1zGQ_fVi2RP6GA@mail.gmail.com>
Download mbox | patch
Permalink /patch/195244/
State Changes Requested
Headers show

Comments

Robert Shade - Oct. 30, 2012, 2:08 a.m.
scan_freq and freq_list are not parsed by wpa_config_parse_freqs if quoted

---
 wpa_supplicant/dbus/dbus_new_handlers.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

 static dbus_bool_t should_quote_opt(const char *key)
Jouni Malinen - Nov. 3, 2012, 10:06 a.m.
On Mon, Oct 29, 2012 at 10:08:12PM -0400, Robert Shade wrote:
> scan_freq and freq_list are not parsed by wpa_config_parse_freqs if quoted

The change itself looks fine, but could you please read the top level
CONTRIBUTIONS file (*) and re-send this with the Signed-hostap: tag in
the commit log so that I can apply it?

(*)
http://w1.fi/gitweb/gitweb.cgi?p=hostap.git;a=blob_plain;f=CONTRIBUTIONS;hb=HEAD
Robert Shade - Nov. 6, 2012, 2:27 a.m.
scan_freq and freq_list are not parsed by wpa_config_parse_freqs if quoted

Signed-hostap: Robert Shade <robert.shade@gmail.com>

--- wpa_supplicant/dbus/dbus_new_handlers.c | 2 +- 1 files changed, 1
insertions(+), 1 deletions(-) diff --git
a/wpa_supplicant/dbus/dbus_new_handlers.c
b/wpa_supplicant/dbus/dbus_new_handlers.c index 00378be..4229157 100644 ---
a/wpa_supplicant/dbus/dbus_new_handlers.c +++
b/wpa_supplicant/dbus/dbus_new_handlers.c @@ -124,7 +124,7 @@ DBusMessage *
wpas_dbus_error_invalid_args(DBusMessage *message, static const char
*dont_quote[] = { "key_mgmt", "proto", "pairwise", "auth_alg", "group",
"eap", "opensc_engine_path", "pkcs11_engine_path", "pkcs11_module_path", -
"bssid", NULL + "bssid", "scan_freq", "freq_list", NULL }; static
dbus_bool_t should_quote_opt(const char *key) -- 1.7.1

Patch

diff --git a/wpa_supplicant/dbus/dbus_new_handlers.c
b/wpa_supplicant/dbus/dbus_new_handlers.c
index 00378be..4229157 100644
--- a/wpa_supplicant/dbus/dbus_new_handlers.c
+++ b/wpa_supplicant/dbus/dbus_new_handlers.c
@@ -124,7 +124,7 @@  DBusMessage *
wpas_dbus_error_invalid_args(DBusMessage *message,
 static const char *dont_quote[] = {
 	"key_mgmt", "proto", "pairwise", "auth_alg", "group", "eap",
 	"opensc_engine_path", "pkcs11_engine_path", "pkcs11_module_path",
-	"bssid", NULL
+	"bssid", "scan_freq", "freq_list", NULL
 };