Patchwork [U-Boot] mv-common.h: increase malloc arena to 4MiB

login
register
mail settings
Submitter Andreas Bießmann
Date Oct. 29, 2012, 11:58 p.m.
Message ID <1351555135-11641-1-git-send-email-andreas.devel@googlemail.com>
Download mbox | patch
Permalink /patch/195174/
State Accepted
Delegated to: Prafulla Wadaskar
Headers show

Comments

Andreas Bießmann - Oct. 29, 2012, 11:58 p.m.
This will fix the following error:

---8<---
UBIFS error (pid 0): ubifs_mount: Error reading superblock on volume 'ubi:root' errno=-12!
--->8---

Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com>
Cc: prafulla@marvell.com
Cc: dimax.main@gmail.com
---
 include/configs/mv-common.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Vikram Narayanan - Oct. 31, 2012, 4:29 p.m.
Hello Andreas,

On 10/30/2012 5:28 AM, Andreas Bießmann wrote:
> This will fix the following error:
>
> ---8<---
> UBIFS error (pid 0): ubifs_mount: Error reading superblock on volume 'ubi:root' errno=-12!
> --->8---

Did this solve the ubifs mount issue?
Did someone test it?

~Vikram
Andreas Bießmann - Oct. 31, 2012, 4:32 p.m.
Dear Vikram Narayanan,

On 31.10.2012 17:29, Vikram Narayanan wrote:
> Hello Andreas,
> 
> On 10/30/2012 5:28 AM, Andreas Bießmann wrote:
>> This will fix the following error:
>>
>> ---8<---
>> UBIFS error (pid 0): ubifs_mount: Error reading superblock on volume
>> 'ubi:root' errno=-12!
>> --->8---
> 
> Did this solve the ubifs mount issue?

It fixes the ENOMEM issue described in
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/145654

> Did someone test it?

Yes, I did.

Best regards

Andreas Bießmann
Dimax - Nov. 12, 2012, 7:51 p.m.
Tested-by: Alex Xol <dimax.main@gmail.com>

On Tue, Oct 30, 2012 at 1:58 AM, Andreas Bießmann
<andreas.devel@googlemail.com> wrote:
> This will fix the following error:
>
> ---8<---
> UBIFS error (pid 0): ubifs_mount: Error reading superblock on volume 'ubi:root' errno=-12!
> --->8---
>
> Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com>
> Cc: prafulla@marvell.com
> Cc: dimax.main@gmail.com
> ---
>  include/configs/mv-common.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/mv-common.h b/include/configs/mv-common.h
> index 7086d1d..405a842 100644
> --- a/include/configs/mv-common.h
> +++ b/include/configs/mv-common.h
> @@ -92,7 +92,7 @@
>  /*
>   * Size of malloc() pool
>   */
> -#define CONFIG_SYS_MALLOC_LEN  (1024 * 1024) /* 1MiB for malloc() */
> +#define CONFIG_SYS_MALLOC_LEN  (1024 * 1024 * 4) /* 4MiB for malloc() */
>
>  /*
>   * Other required minimal configurations
> --
> 1.7.10.4
>
Andreas Bießmann - Dec. 9, 2012, 4:49 p.m.
ping?

On 10/30/2012 12:58 AM, Andreas Bießmann wrote:
> This will fix the following error:
>
> ---8<---
> UBIFS error (pid 0): ubifs_mount: Error reading superblock on volume 'ubi:root' errno=-12!
> --->8---
>
> Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com>
> Cc: prafulla@marvell.com
> Cc: dimax.main@gmail.com
> ---
>   include/configs/mv-common.h |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/mv-common.h b/include/configs/mv-common.h
> index 7086d1d..405a842 100644
> --- a/include/configs/mv-common.h
> +++ b/include/configs/mv-common.h
> @@ -92,7 +92,7 @@
>   /*
>    * Size of malloc() pool
>    */
> -#define CONFIG_SYS_MALLOC_LEN	(1024 * 1024) /* 1MiB for malloc() */
> +#define CONFIG_SYS_MALLOC_LEN	(1024 * 1024 * 4) /* 4MiB for malloc() */
>
>   /*
>    * Other required minimal configurations
>
Prafulla Wadaskar - Dec. 10, 2012, 6:42 a.m.
> -----Original Message-----
> From: Andreas Bießmann [mailto:andreas.devel@googlemail.com]
> Sent: 09 December 2012 22:20
> To: Andreas Bießmann
> Cc: U-Boot List; Prafulla Wadaskar
> Subject: Re: [PATCH] mv-common.h: increase malloc arena to 4MiB
> 
> ping?

Hi Andreas
Sorry for the delay :-(
I will pull this in this week.

Regards...
Prafulla . . .

> 
> On 10/30/2012 12:58 AM, Andreas Bießmann wrote:
> > This will fix the following error:
> >
> > ---8<---
> > UBIFS error (pid 0): ubifs_mount: Error reading superblock on volume
> 'ubi:root' errno=-12!
> > --->8---
> >
> > Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com>
> > Cc: prafulla@marvell.com
> > Cc: dimax.main@gmail.com
> > ---
> >   include/configs/mv-common.h |    2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/configs/mv-common.h b/include/configs/mv-
> common.h
> > index 7086d1d..405a842 100644
> > --- a/include/configs/mv-common.h
> > +++ b/include/configs/mv-common.h
> > @@ -92,7 +92,7 @@
> >   /*
> >    * Size of malloc() pool
> >    */
> > -#define CONFIG_SYS_MALLOC_LEN	(1024 * 1024) /* 1MiB for malloc()
> */
> > +#define CONFIG_SYS_MALLOC_LEN	(1024 * 1024 * 4) /* 4MiB for
> malloc() */
> >
> >   /*
> >    * Other required minimal configurations
> >
Prafulla Wadaskar - Dec. 20, 2012, 9:31 a.m.
> -----Original Message-----
> From: Andreas Bießmann [mailto:andreas.devel@googlemail.com]
> Sent: 30 October 2012 05:29
> To: U-Boot List
> Cc: Andreas Bießmann; Prafulla Wadaskar; dimax.main@gmail.com
> Subject: [PATCH] mv-common.h: increase malloc arena to 4MiB
> 
> This will fix the following error:
> 
> ---8<---
> UBIFS error (pid 0): ubifs_mount: Error reading superblock on volume
> 'ubi:root' errno=-12!
> --->8---
> 
> Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com>
> Cc: prafulla@marvell.com
> Cc: dimax.main@gmail.com
> ---
>  include/configs/mv-common.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/mv-common.h b/include/configs/mv-common.h
> index 7086d1d..405a842 100644
> --- a/include/configs/mv-common.h
> +++ b/include/configs/mv-common.h
> @@ -92,7 +92,7 @@
>  /*
>   * Size of malloc() pool
>   */
> -#define CONFIG_SYS_MALLOC_LEN	(1024 * 1024) /* 1MiB for malloc()
> */
> +#define CONFIG_SYS_MALLOC_LEN	(1024 * 1024 * 4) /* 4MiB for
> malloc() */
> 
>  /*
>   * Other required minimal configurations
> --
> 1.7.10.4

Applied to u-boot-marvell.git master branch

Regards...
Prafulla . . .
Andreas Bießmann - Dec. 20, 2012, 9:48 a.m.
Dear Prafulla Wadaskar,

On 20.12.2012 10:31, Prafulla Wadaskar wrote:
> 
> 
>> -----Original Message-----
>> From: Andreas Bießmann [mailto:andreas.devel@googlemail.com]
>> Sent: 30 October 2012 05:29
>> To: U-Boot List
>> Cc: Andreas Bießmann; Prafulla Wadaskar; dimax.main@gmail.com
>> Subject: [PATCH] mv-common.h: increase malloc arena to 4MiB
>>
>> This will fix the following error:
>>
>> ---8<---
>> UBIFS error (pid 0): ubifs_mount: Error reading superblock on volume
>> 'ubi:root' errno=-12!
>> --->8---

<snip>

> Applied to u-boot-marvell.git master branch

I've just seen you requested a pull before this add. Would be great to
have this patch in 2013.01

Best regards

Andreas Bießmann
Prafulla Wadaskar - Dec. 20, 2012, 10:01 a.m.
> -----Original Message-----
> From: Andreas Bießmann [mailto:andreas.devel@googlemail.com]
> Sent: 20 December 2012 15:19
> To: Prafulla Wadaskar
> Cc: Andreas Bießmann; U-Boot List; dimax.main@gmail.com
> Subject: Re: [PATCH] mv-common.h: increase malloc arena to 4MiB
> 
> Dear Prafulla Wadaskar,
> 
> On 20.12.2012 10:31, Prafulla Wadaskar wrote:
> >
> >
> >> -----Original Message-----
> >> From: Andreas Bießmann [mailto:andreas.devel@googlemail.com]
> >> Sent: 30 October 2012 05:29
> >> To: U-Boot List
> >> Cc: Andreas Bießmann; Prafulla Wadaskar; dimax.main@gmail.com
> >> Subject: [PATCH] mv-common.h: increase malloc arena to 4MiB
> >>
> >> This will fix the following error:
> >>
> >> ---8<---
> >> UBIFS error (pid 0): ubifs_mount: Error reading superblock on
> volume
> >> 'ubi:root' errno=-12!
> >> --->8---
> 
> <snip>
> 
> > Applied to u-boot-marvell.git master branch
> 
> I've just seen you requested a pull before this add. Would be great to
> have this patch in 2013.01
> 
> Best regards
> 
> Andreas Bießmann

Dear Andreas,
Sure
I will resend the pull request.

Regards...
Prafulla . . .

Patch

diff --git a/include/configs/mv-common.h b/include/configs/mv-common.h
index 7086d1d..405a842 100644
--- a/include/configs/mv-common.h
+++ b/include/configs/mv-common.h
@@ -92,7 +92,7 @@ 
 /*
  * Size of malloc() pool
  */
-#define CONFIG_SYS_MALLOC_LEN	(1024 * 1024) /* 1MiB for malloc() */
+#define CONFIG_SYS_MALLOC_LEN	(1024 * 1024 * 4) /* 4MiB for malloc() */
 
 /*
  * Other required minimal configurations