Patchwork [U-Boot,v2,20/25] drivers/input/input.c: sparse fix

login
register
mail settings
Submitter Kim Phillips
Date Oct. 29, 2012, 11:34 p.m.
Message ID <1351553687-12469-21-git-send-email-kim.phillips@freescale.com>
Download mbox | patch
Permalink /patch/195159/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Kim Phillips - Oct. 29, 2012, 11:34 p.m.
input.c:97:5: warning: symbol 'input_queue_ascii' was not declared. Should it be

Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
---
v2: no changes

 drivers/input/input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Simon Glass - Oct. 31, 2012, 5:51 a.m.
On Mon, Oct 29, 2012 at 4:34 PM, Kim Phillips
<kim.phillips@freescale.com> wrote:
> input.c:97:5: warning: symbol 'input_queue_ascii' was not declared. Should it be
>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>

Acked-by: Simon Glass <sjg@chromium.org>

> ---
> v2: no changes
>
>  drivers/input/input.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/input.c b/drivers/input/input.c
> index 9800667..04fa5f0 100644
> --- a/drivers/input/input.c
> +++ b/drivers/input/input.c
> @@ -110,7 +110,7 @@ static struct {
>  /* Maximum number of output characters that an ANSI sequence expands to */
>  #define ANSI_CHAR_MAX  3
>
> -int input_queue_ascii(struct input_config *config, int ch)
> +static int input_queue_ascii(struct input_config *config, int ch)
>  {
>         if (config->fifo_in + 1 == INPUT_BUFFER_LEN) {
>                 if (!config->fifo_out)
> --
> 1.8.0
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Patch

diff --git a/drivers/input/input.c b/drivers/input/input.c
index 9800667..04fa5f0 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -110,7 +110,7 @@  static struct {
 /* Maximum number of output characters that an ANSI sequence expands to */
 #define ANSI_CHAR_MAX	3
 
-int input_queue_ascii(struct input_config *config, int ch)
+static int input_queue_ascii(struct input_config *config, int ch)
 {
 	if (config->fifo_in + 1 == INPUT_BUFFER_LEN) {
 		if (!config->fifo_out)