Patchwork [v3] fix PR 55123

login
register
mail settings
Submitter Jonathan Wakely
Date Oct. 29, 2012, 10:02 p.m.
Message ID <CAH6eHdTeTUW6R31_UW4kAxj_Jk1Yn02D5V-AP9g271YBgOGkVQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/195141/
State New
Headers show

Comments

Jonathan Wakely - Oct. 29, 2012, 10:02 p.m.
PR libstdc++/55123
        * include/bits/shared_ptr_base.h (__shared_count::_S_create_from_up):
        Do not instantiate allocator with element_type.
        * testsuite/20_util/shared_ptr/cons/55123.cc: New.

Tested x86-64-linux, committed to trunk and 4.7
commit 3a994d1a811d62cd87a3e97accf655ef1c34eb51
Author: Jonathan Wakely <jwakely.gcc@gmail.com>
Date:   Mon Oct 29 21:20:05 2012 +0000

    	PR libstdc++/55123
    	* include/bits/shared_ptr_base.h (__shared_count::_S_create_from_up):
    	Do not instantiate allocator with element_type.
    	* testsuite/20_util/shared_ptr/cons/55123.cc: New.

Patch

diff --git a/libstdc++-v3/include/bits/shared_ptr_base.h b/libstdc++-v3/include/bits/shared_ptr_base.h
index 07ac000..e48a8fb 100644
--- a/libstdc++-v3/include/bits/shared_ptr_base.h
+++ b/libstdc++-v3/include/bits/shared_ptr_base.h
@@ -622,7 +622,7 @@  _GLIBCXX_BEGIN_NAMESPACE_VERSION
 	_S_create_from_up(std::unique_ptr<_Tp, _Del>&& __r,
 	  typename std::enable_if<!std::is_reference<_Del>::value>::type* = 0)
 	{
-	  return new _Sp_counted_deleter<_Tp*, _Del, std::allocator<_Tp>,
+	  return new _Sp_counted_deleter<_Tp*, _Del, std::allocator<void>,
 	    _Lp>(__r.get(), __r.get_deleter());
 	}
 
@@ -633,7 +633,7 @@  _GLIBCXX_BEGIN_NAMESPACE_VERSION
 	{
 	  typedef typename std::remove_reference<_Del>::type _Del1;
 	  typedef std::reference_wrapper<_Del1> _Del2;
-	  return new _Sp_counted_deleter<_Tp*, _Del2, std::allocator<_Tp>,
+	  return new _Sp_counted_deleter<_Tp*, _Del2, std::allocator<void>,
 	    _Lp>(__r.get(), std::ref(__r.get_deleter()));
 	}
 
diff --git a/libstdc++-v3/testsuite/20_util/shared_ptr/cons/55123.cc b/libstdc++-v3/testsuite/20_util/shared_ptr/cons/55123.cc
new file mode 100644
index 0000000..35b517e
--- /dev/null
+++ b/libstdc++-v3/testsuite/20_util/shared_ptr/cons/55123.cc
@@ -0,0 +1,30 @@ 
+// { dg-options "-std=gnu++0x" }
+// { dg-do compile }
+
+// Copyright (C) 2012 Free Software Foundation
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+#include <memory>
+
+// libstdc++/55123
+
+#include <memory>
+
+void f() {
+  std::unique_ptr<const int> y;
+  std::shared_ptr<const int> x = std::move(y);
+}