Patchwork [3/6] Add firmware for the AW-NH580 connectivity module of the snowball

login
register
mail settings
Submitter Gregory Hermant
Date Oct. 29, 2012, 8:41 a.m.
Message ID <1351500073-4351-4-git-send-email-gregory.hermant@calao-systems.com>
Download mbox | patch
Permalink /patch/194884/
State Superseded
Headers show

Comments

Gregory Hermant - Oct. 29, 2012, 8:41 a.m.
Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
---
 package/Config.in                              |    1 +
 package/snowball-firmware/Config.in            |    8 ++++++++
 package/snowball-firmware/snowball-firmware.mk |   17 +++++++++++++++++
 3 files changed, 26 insertions(+)
 create mode 100644 package/snowball-firmware/Config.in
 create mode 100644 package/snowball-firmware/snowball-firmware.mk
Arnout Vandecappelle - Oct. 30, 2012, 10:34 p.m.
Subject line should be <pkg>: new package

On 10/29/12 09:41, Gregory Hermant wrote:
>
> Signed-off-by: Gregory Hermant<gregory.hermant@calao-systems.com>
> ---
>   package/Config.in                              |    1 +
>   package/snowball-firmware/Config.in            |    8 ++++++++
>   package/snowball-firmware/snowball-firmware.mk |   17 +++++++++++++++++
>   3 files changed, 26 insertions(+)
>   create mode 100644 package/snowball-firmware/Config.in
>   create mode 100644 package/snowball-firmware/snowball-firmware.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 097a94d..fd5281f 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -532,6 +532,7 @@ source "package/googlefontdirectory/Config.in"
>   source "package/hdmiservice/Config.in"
>   source "package/mobile-broadband-provider-info/Config.in"
>   source "package/shared-mime-info/Config.in"
> +source "package/snowball-firmware/Config.in"

  Again, Hardware handling is a more appropriate menu.
It's where linux-firmware resides...

>   source "package/sound-theme-borealis/Config.in"
>   source "package/sound-theme-freedesktop/Config.in"
>   endmenu
> diff --git a/package/snowball-firmware/Config.in b/package/snowball-firmware/Config.in
> new file mode 100644
> index 0000000..1d0789d
> --- /dev/null
> +++ b/package/snowball-firmware/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_SNOWBALL_FIRMWARE
> +	bool "snowball-firmware"
> +	help
> +	  This package provides various binary firmware files (closed binary blobs)
> +	  for the Azurewave AW-NH580 combo module (wifi, bt, gps).
> +
> +	  https://git.kernel.org/?p=linux/kernel/git/firmware/linux-firmware.git

  Funny URL...

> +
> diff --git a/package/snowball-firmware/snowball-firmware.mk b/package/snowball-firmware/snowball-firmware.mk
> new file mode 100644
> index 0000000..05326e2
> --- /dev/null
> +++ b/package/snowball-firmware/snowball-firmware.mk
> @@ -0,0 +1,17 @@
> +#############################################################
> +#
> +# snowball-firmware
> +#
> +#############################################################
> +SNOWBALL_FIRMWARE_VERSION = 1.1.3-5
> +SNOWBALL_FIRMWARE_SOURCE = ux500-firmware_$(SNOWBALL_FIRMWARE_VERSION).tar.gz
> +SNOWBALL_FIRMWARE_SITE = https://launchpad.net/~linaro-maintainers/+archive/overlay/+files/
> +SNOWBALL_FIRMWARE_LICENSE = PROPRIETARY

  Again not a very accurate license.  "Snowball click-wrap license" is more
appropriate.  It does come pretty close to proprietary, however.  I wonder
if the linaro maintainers have permission to redistribute it via launchpad...

  The license file is license.txt.

> +
> +define SNOWBALL_FIRMWARE_INSTALL_TARGET_CMDS
> +	mkdir -p $(TARGET_DIR)/lib/firmware
> +	cp -r $(@D)/* $(TARGET_DIR)/lib/firmware/

  I'd prefer 'make install' here.

> +	rename 's/CG2900/CG29XX/' $(TARGET_DIR)/lib/firmware/*.fw

  We try to avoid relying on non-Posix shell utilities like rename.


  Regards,
  Arnout

> +endef
> +
> +$(eval $(generic-package))
Arnout Vandecappelle - Oct. 30, 2012, 10:35 p.m.
On 10/29/12 09:41, Gregory Hermant wrote:
> +SNOWBALL_FIRMWARE_SOURCE = ux500-firmware_$(SNOWBALL_FIRMWARE_VERSION).tar.gz

  And it looks like ux500-firmware would be a more appropriate package name.

  Regards,
  Arnout
Gregory Hermant - Nov. 8, 2012, 8:47 a.m.
Le 30/10/2012 23:34, Arnout Vandecappelle a écrit :
> 
>> +
>> diff --git a/package/snowball-firmware/snowball-firmware.mk b/package/snowball-firmware/snowball-firmware.mk
>> new file mode 100644
>> index 0000000..05326e2
>> --- /dev/null
>> +++ b/package/snowball-firmware/snowball-firmware.mk
>> @@ -0,0 +1,17 @@
>> +#############################################################
>> +#
>> +# snowball-firmware
>> +#
>> +#############################################################
>> +SNOWBALL_FIRMWARE_VERSION = 1.1.3-5
>> +SNOWBALL_FIRMWARE_SOURCE = ux500-firmware_$(SNOWBALL_FIRMWARE_VERSION).tar.gz
>> +SNOWBALL_FIRMWARE_SITE = https://launchpad.net/~linaro-maintainers/+archive/overlay/+files/
>> +SNOWBALL_FIRMWARE_LICENSE = PROPRIETARY
> 
>  Again not a very accurate license.  "Snowball click-wrap license" is more
> appropriate.  It does come pretty close to proprietary, however.  I wonder
> if the linaro maintainers have permission to redistribute it via launchpad...
> 
>  The license file is license.txt.

What do you suggest for the UX500_FIRMWARE_LICENSE = ?
BR,
gregory
Arnout Vandecappelle - Nov. 10, 2012, 2:16 a.m.
On 11/08/12 09:47, Grégory Hermant wrote:
>>> >>  +SNOWBALL_FIRMWARE_LICENSE = PROPRIETARY
>> >
>> >    Again not a very accurate license.  "Snowball click-wrap license" is more
>> >  appropriate.  It does come pretty close to proprietary, however.  I wonder
>> >  if the linaro maintainers have permission to redistribute it via launchpad...
>> >
>> >    The license file is license.txt.
> What do you suggest for the UX500_FIRMWARE_LICENSE = ?

  I would set
UX500_FIRMWARE_LICENSE = Snowball click-wrap license
UX500_FIRMWARE_DISTRIBUTE = NO

And then we also have a use case for Luca's new no-distribute function.
Can you test a 'make legal-info' with this?  It should not store the
ux500-firmware tarball to the legal-info/sources directory.

  Regards,
  Arnout
Gregory Hermant - Nov. 13, 2012, 11:08 a.m.
Le 10/11/2012 03:16, Arnout Vandecappelle a écrit :
> On 11/08/12 09:47, Grégory Hermant wrote:
>>>> >>  +SNOWBALL_FIRMWARE_LICENSE = PROPRIETARY
>>> >
>>> >    Again not a very accurate license.  "Snowball click-wrap license" is more
>>> >  appropriate.  It does come pretty close to proprietary, however.  I wonder
>>> >  if the linaro maintainers have permission to redistribute it via launchpad...
>>> >
>>> >    The license file is license.txt.
>> What do you suggest for the UX500_FIRMWARE_LICENSE = ?
> 
>  I would set
> UX500_FIRMWARE_LICENSE = Snowball click-wrap license
> UX500_FIRMWARE_DISTRIBUTE = NO
> 
> And then we also have a use case for Luca's new no-distribute function.
> Can you test a 'make legal-info' with this?  It should not store the
> ux500-firmware tarball to the legal-info/sources directory.
Indeed the ux500-firmware tarball is not stored to the legal-info/sources directory.
> 
>  Regards,
>  Arnout
> 

BR,
gregory

Patch

diff --git a/package/Config.in b/package/Config.in
index 097a94d..fd5281f 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -532,6 +532,7 @@  source "package/googlefontdirectory/Config.in"
 source "package/hdmiservice/Config.in"
 source "package/mobile-broadband-provider-info/Config.in"
 source "package/shared-mime-info/Config.in"
+source "package/snowball-firmware/Config.in"
 source "package/sound-theme-borealis/Config.in"
 source "package/sound-theme-freedesktop/Config.in"
 endmenu
diff --git a/package/snowball-firmware/Config.in b/package/snowball-firmware/Config.in
new file mode 100644
index 0000000..1d0789d
--- /dev/null
+++ b/package/snowball-firmware/Config.in
@@ -0,0 +1,8 @@ 
+config BR2_PACKAGE_SNOWBALL_FIRMWARE
+	bool "snowball-firmware"
+	help
+	  This package provides various binary firmware files (closed binary blobs)
+	  for the Azurewave AW-NH580 combo module (wifi, bt, gps).
+
+	  https://git.kernel.org/?p=linux/kernel/git/firmware/linux-firmware.git
+
diff --git a/package/snowball-firmware/snowball-firmware.mk b/package/snowball-firmware/snowball-firmware.mk
new file mode 100644
index 0000000..05326e2
--- /dev/null
+++ b/package/snowball-firmware/snowball-firmware.mk
@@ -0,0 +1,17 @@ 
+#############################################################
+#
+# snowball-firmware
+#
+#############################################################
+SNOWBALL_FIRMWARE_VERSION = 1.1.3-5
+SNOWBALL_FIRMWARE_SOURCE = ux500-firmware_$(SNOWBALL_FIRMWARE_VERSION).tar.gz
+SNOWBALL_FIRMWARE_SITE = https://launchpad.net/~linaro-maintainers/+archive/overlay/+files/
+SNOWBALL_FIRMWARE_LICENSE = PROPRIETARY
+
+define SNOWBALL_FIRMWARE_INSTALL_TARGET_CMDS
+	mkdir -p $(TARGET_DIR)/lib/firmware
+	cp -r $(@D)/* $(TARGET_DIR)/lib/firmware/
+	rename 's/CG2900/CG29XX/' $(TARGET_DIR)/lib/firmware/*.fw
+endef
+
+$(eval $(generic-package))