Patchwork ext4: get rid of the duplicate code on ext4_fill_super

login
register
mail settings
Submitter Zhao Hongjiang
Date Oct. 29, 2012, 7:32 a.m.
Message ID <508E30F8.3090606@gmail.com>
Download mbox | patch
Permalink /patch/194865/
State Accepted, archived
Headers show

Comments

Zhao Hongjiang - Oct. 29, 2012, 7:32 a.m.
From: Zhao Hongjiang <zhaohongjiang@huawei.com>

Clean the duplicate code on ext4_fill_super cause the bellow
also have it.

Signed-off-by: Zhao Hongjiang <zhaohongjiang@huawei.com>
---
 fs/ext4/super.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

-- 1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Theodore Ts'o - Nov. 8, 2012, 5:14 p.m.
On Mon, Oct 29, 2012 at 03:32:08PM +0800, Zhao Hongjiang wrote:
> From: Zhao Hongjiang <zhaohongjiang@huawei.com>
> 
> Clean the duplicate code on ext4_fill_super cause the bellow
> also have it.
> 
> Signed-off-by: Zhao Hongjiang <zhaohongjiang@huawei.com>

Applied, thanks!

I used the commit description:

     ext4: get rid of redundant code in ext4_fill_super()

     	       	      		     	- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 80928f7..d21b985 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -3272,9 +3272,6 @@  static int ext4_fill_super(struct super_block *sb, void *data, int silent)
 	}
 	sb->s_fs_info = sbi;
 	sbi->s_sb = sb;
-	sbi->s_mount_opt = 0;
-	sbi->s_resuid = make_kuid(&init_user_ns, EXT4_DEF_RESUID);
-	sbi->s_resgid = make_kgid(&init_user_ns, EXT4_DEF_RESGID);
 	sbi->s_inode_readahead_blks = EXT4_DEF_INODE_READAHEAD_BLKS;
 	sbi->s_sb_block = sb_block;
 	if (sb->s_bdev->bd_part)