[1/2] rndis_wlan: allow devdbg arguments to be type-checked without DEBUG
diff mbox

Message ID 1232456838-10025-1-git-send-email-steve.glendinning@smsc.com
State Rejected, archived
Delegated to: David Miller
Headers show

Commit Message

Steve Glendinning Jan. 20, 2009, 1:07 p.m. UTC
This patch removes an #ifdef DEBUG directive so devdbg statements can be
type-checked at compile time.  Type checking itself is introduced by
another patch in this series.

This introduces an unused variable warning which disappears with the
type-checking patch.

Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
---
 drivers/net/wireless/rndis_wlan.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Comments

David Miller Jan. 20, 2009, 5:06 p.m. UTC | #1
From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Tue, 20 Jan 2009 13:07:17 +0000

> This patch removes an #ifdef DEBUG directive so devdbg statements can be
> type-checked at compile time.  Type checking itself is introduced by
> another patch in this series.
> 
> This introduces an unused variable warning which disappears with the
> type-checking patch.
> 
> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>

This adds a warning for the non-DEBUG build.  That's the whole reason
the ifdef is there.

Therefore you must do the devdbg() define change and this ifdef
removal in the same commit.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c
index 607ce9f..ed93ac4 100644
--- a/drivers/net/wireless/rndis_wlan.c
+++ b/drivers/net/wireless/rndis_wlan.c
@@ -1649,9 +1649,7 @@  static char *rndis_translate_scan(struct net_device *dev,
 				  char *end_buf,
 				  struct ndis_80211_bssid_ex *bssid)
 {
-#ifdef DEBUG
 	struct usbnet *usbdev = netdev_priv(dev);
-#endif
 	u8 *ie;
 	char *current_val;
 	int bssid_len, ie_len, i;