From patchwork Tue Jan 20 13:07:18 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Glendinning X-Patchwork-Id: 19477 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 4D027DDF1E for ; Wed, 21 Jan 2009 00:31:54 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756253AbZATNbu (ORCPT ); Tue, 20 Jan 2009 08:31:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755880AbZATNbs (ORCPT ); Tue, 20 Jan 2009 08:31:48 -0500 Received: from sandgatehouse.force9.co.uk ([84.92.144.20]:48199 "EHLO kensington.shawell.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754995AbZATNbs (ORCPT ); Tue, 20 Jan 2009 08:31:48 -0500 X-Greylist: delayed 789 seconds by postgrey-1.27 at vger.kernel.org; Tue, 20 Jan 2009 08:31:47 EST Received: from localhost.localdomain (kensington.shawell.net [127.0.0.1]) by kensington.shawell.net (Postfix) with ESMTP id DC1364A4109; Tue, 20 Jan 2009 13:07:18 +0000 (GMT) From: Steve Glendinning To: netdev@vger.kernel.org Cc: David Miller , David Brownell , Steve Glendinning Subject: [PATCH 2/2] usbnet: allow type check of devdbg arguments in non-debug build Date: Tue, 20 Jan 2009 13:07:18 +0000 Message-Id: <1232456838-10025-2-git-send-email-steve.glendinning@smsc.com> X-Mailer: git-send-email 1.6.0.6 In-Reply-To: <1232456838-10025-1-git-send-email-steve.glendinning@smsc.com> References: <1232456838-10025-1-git-send-email-steve.glendinning@smsc.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Improve usbnet's devdbg to always type-check diagnostic arguments, like dev_dbg (device.h). This makes no change to the resulting size of usbnet modules. Signed-off-by: Steve Glendinning Signed-off-by: David Brownell --- include/linux/usb/usbnet.h | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/include/linux/usb/usbnet.h b/include/linux/usb/usbnet.h index ba09fe8..7d38222 100644 --- a/include/linux/usb/usbnet.h +++ b/include/linux/usb/usbnet.h @@ -197,7 +197,9 @@ extern int usbnet_nway_reset(struct net_device *net); #define devdbg(usbnet, fmt, arg...) \ printk(KERN_DEBUG "%s: " fmt "\n" , (usbnet)->net->name , ## arg) #else -#define devdbg(usbnet, fmt, arg...) do {} while(0) +#define devdbg(usbnet, fmt, arg...) \ + ({ if (0) printk(KERN_DEBUG "%s: " fmt "\n" , (usbnet)->net->name , \ + ## arg); 0; }) #endif #define deverr(usbnet, fmt, arg...) \