From patchwork Sun Oct 28 16:12:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Senna Tschudin X-Patchwork-Id: 194716 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id BE2A82C0090 for ; Mon, 29 Oct 2012 03:12:48 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753182Ab2J1QMh (ORCPT ); Sun, 28 Oct 2012 12:12:37 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:49019 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514Ab2J1QMP (ORCPT ); Sun, 28 Oct 2012 12:12:15 -0400 Received: by mail-wi0-f178.google.com with SMTP id hr7so1572562wib.1 for ; Sun, 28 Oct 2012 09:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=BDtp2UazNp/8PXuHl3NyDaQ4VGdw9CR5eIiim2mvzhs=; b=n/dJjFzwnQ7QeMRAvAVcto+8qiJC4iDl4wkyV5wnjfqGPkbT6+aOS4hW5TEYkt/eLL 80mrxCmbvYRuANaYo3fLg1F4BSlZDefRAs/jVE6rx3eZu9VKZpSlbH7REQDGN0llv07g fs32SjSjRzQHi8laadhi1FKtEtRjIxEFKY6ryqBTraXqw+IxLZLO6hi+SDJlpm9cvmF1 bHvmyrHPIHgomSBPnJfaBrx/a7SB/TT6eZVKqvgAHcm8bkfDmoB4PqLJQwFZSA11ZsPq ResMM1uAs4yuDPLybTSYTs58hKSAzfNP43Dx0JJJ7NbHxuHpPbAx2+cmtmbAQRhylltS FU7Q== Received: by 10.216.195.100 with SMTP id o78mr16399183wen.182.1351440734231; Sun, 28 Oct 2012 09:12:14 -0700 (PDT) Received: from ace.home ([37.175.194.0]) by mx.google.com with ESMTPS id k20sm6395318wiv.11.2012.10.28.09.12.12 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 28 Oct 2012 09:12:13 -0700 (PDT) From: Peter Senna Tschudin To: davem@davemloft.net Cc: srinivas.kandagatla@st.com, peter.senna@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 2/2] drivers/net/phy/mdio-bitbang.c: Call mdiobus_unregister before mdiobus_free Date: Sun, 28 Oct 2012 17:12:01 +0100 Message-Id: <1351440721-9121-2-git-send-email-peter.senna@gmail.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1351440721-9121-1-git-send-email-peter.senna@gmail.com> References: <1351440721-9121-1-git-send-email-peter.senna@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Based on commit b27393aecf66199f5ddad37c302d3e0cfadbe6c0 Calling mdiobus_free without calling mdiobus_unregister causes BUG_ON(). This patch fixes the issue. The semantic patch that found this issue(http://coccinelle.lip6.fr/): // @@ expression E; @@ ... when != mdiobus_unregister(E); + mdiobus_unregister(E); mdiobus_free(E); // Signed-off-by: Peter Senna Tschudin --- This problem is somewhat mystifying. If the patch is correct, there were probably many OOPSese caused by not calling mdiobus_unregister... Reporting anyway... drivers/net/phy/mdio-bitbang.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/mdio-bitbang.c b/drivers/net/phy/mdio-bitbang.c index daec9b0..6428fcb 100644 --- a/drivers/net/phy/mdio-bitbang.c +++ b/drivers/net/phy/mdio-bitbang.c @@ -234,6 +234,7 @@ void free_mdio_bitbang(struct mii_bus *bus) struct mdiobb_ctrl *ctrl = bus->priv; module_put(ctrl->ops->owner); + mdiobus_unregister(bus); mdiobus_free(bus); } EXPORT_SYMBOL(free_mdio_bitbang);