Patchwork [14/16] batman-adv: properly convert flag into a boolean value

login
register
mail settings
Submitter Antonio Quartulli
Date Oct. 28, 2012, 11:17 a.m.
Message ID <1351423037-5292-15-git-send-email-ordex@autistici.org>
Download mbox | patch
Permalink /patch/194686/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Antonio Quartulli - Oct. 28, 2012, 11:17 a.m.
In order to properly convert a bitwise AND to a boolean value, the whole
expression must be prepended by "!!".

Signed-off-by: Antonio Quartulli <ordex@autistici.org>
---
 net/batman-adv/translation-table.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
index 0ac39d5..c61209f 100644
--- a/net/batman-adv/translation-table.c
+++ b/net/batman-adv/translation-table.c
@@ -2420,7 +2420,7 @@  bool batadv_tt_global_client_is_roaming(struct batadv_priv *bat_priv,
 	if (!tt_global_entry)
 		goto out;
 
-	ret = tt_global_entry->common.flags & BATADV_TT_CLIENT_ROAM;
+	ret = !!(tt_global_entry->common.flags & BATADV_TT_CLIENT_ROAM);
 	batadv_tt_global_entry_free_ref(tt_global_entry);
 out:
 	return ret;