From patchwork Sun Oct 28 07:19:02 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 194651 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 870082C008D for ; Sun, 28 Oct 2012 18:21:26 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TSNA8-0001Lc-VD; Sun, 28 Oct 2012 07:20:01 +0000 Received: from mail-da0-f49.google.com ([209.85.210.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TSN9r-0001Jc-HP for linux-mtd@lists.infradead.org; Sun, 28 Oct 2012 07:19:44 +0000 Received: by mail-da0-f49.google.com with SMTP id q27so1746313daj.36 for ; Sun, 28 Oct 2012 00:19:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=s+Eu96tJOA1knh9TOkQD2167r35qLR5N4gyRecAftKs=; b=i2+vfenaALQtiJUt3OWX6rEYInhz65WMBF5O+dhIPWknQEa53TOIwcWsIO446vn8EX KOIMLwneVf9uwiAJ2OlUUZg8byQMfZdKbujcEVYFcV23a8Fs9Q+ZzGcRkDJ4CHHhWAE7 Ejx1DMFU/arFD3W50MsSo3H57Ijtm97717kQxeKJrO4eAhIT1y96HqW1/KlhvTtoQ071 TVaJqtZvSmBKbJDq/pykf81tfmlFjzCOAczmtU/gHsYJdBoy3sRSUtuWywuIb9tQIzF4 O4sQ4Q/hh+htagqw6zhojujVHqscJlZoR3FeyguzWPHjXBg/+LTZRPytTAAsliIDa8x0 NecQ== Received: by 10.66.72.35 with SMTP id a3mr74383271pav.66.1351408782762; Sun, 28 Oct 2012 00:19:42 -0700 (PDT) Received: from localhost.localdomain (p1120-ipbf2201hodogaya.kanagawa.ocn.ne.jp. [123.220.186.120]) by mx.google.com with ESMTPS id lb4sm3961166pbc.6.2012.10.28.00.19.41 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 28 Oct 2012 00:19:42 -0700 (PDT) From: Akinobu Mita To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: [PATCH 5/9] ubifs: use random32_get_bytes Date: Sun, 28 Oct 2012 16:19:02 +0900 Message-Id: <1351408746-8623-5-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1351408746-8623-1-git-send-email-akinobu.mita@gmail.com> References: <1351408746-8623-1-git-send-email-akinobu.mita@gmail.com> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.210.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (akinobu.mita[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Adrian Hunter , linux-mtd@lists.infradead.org, Akinobu Mita , Artem Bityutskiy X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This also converts filling memory loop to use memset. Signed-off-by: Akinobu Mita Cc: Artem Bityutskiy Cc: Adrian Hunter Cc: linux-mtd@lists.infradead.org --- fs/ubifs/debug.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c index 6291163..f3e4a25 100644 --- a/fs/ubifs/debug.c +++ b/fs/ubifs/debug.c @@ -2560,7 +2560,7 @@ static int power_cut_emulated(struct ubifs_info *c, int lnum, int write) static int corrupt_data(const struct ubifs_info *c, const void *buf, unsigned int len) { - unsigned int from, to, i, ffs = chance(1, 2); + unsigned int from, to, ffs = chance(1, 2); unsigned char *p = (void *)buf; from = random32() % (len + 1); @@ -2571,11 +2571,9 @@ static int corrupt_data(const struct ubifs_info *c, const void *buf, ffs ? "0xFFs" : "random data"); if (ffs) - for (i = from; i < to; i++) - p[i] = 0xFF; + memset(p + from, 0xFF, to - from); else - for (i = from; i < to; i++) - p[i] = random32() % 0x100; + random32_get_bytes(p + from, to - from); return to; }