From patchwork Sat Oct 27 00:08:28 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirsher, Jeffrey T" X-Patchwork-Id: 194580 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4E5962C00A3 for ; Sat, 27 Oct 2012 11:08:45 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934325Ab2J0AIn (ORCPT ); Fri, 26 Oct 2012 20:08:43 -0400 Received: from mga01.intel.com ([192.55.52.88]:27325 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934312Ab2J0AIm (ORCPT ); Fri, 26 Oct 2012 20:08:42 -0400 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 26 Oct 2012 17:08:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,657,1344236400"; d="scan'208";a="240741809" Received: from unknown (HELO jtkirshe-mobl.amr.corp.intel.com) ([10.255.14.141]) by fmsmga002.fm.intel.com with ESMTP; 26 Oct 2012 17:08:40 -0700 From: Jeff Kirsher To: davem@davemloft.net Cc: Greg Rose , netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com, Jeff Kirsher Subject: [net-next 02/12] ixgbe: Fix return value from macvlan filter function Date: Fri, 26 Oct 2012 17:08:28 -0700 Message-Id: <1351296518-31174-3-git-send-email-jeffrey.t.kirsher@intel.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1351296518-31174-1-git-send-email-jeffrey.t.kirsher@intel.com> References: <1351296518-31174-1-git-send-email-jeffrey.t.kirsher@intel.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Greg Rose The function to set the macvlan filter should return success or failure instead of the index of the filter. The message processing function was misinterpreting the index as a non-zero return code indicating failure and NACKing MAC filter set messages that actually succeeded. Signed-off-by: Greg Rose Tested-by: Robert Garrett Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c index 96876b7..b68bf0f 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c @@ -742,7 +742,8 @@ static int ixgbe_set_vf_macvlan_msg(struct ixgbe_adapter *adapter, e_warn(drv, "VF %d has requested a MACVLAN filter but there is no space for it\n", vf); - return err; + + return !!err < 0; } static int ixgbe_negotiate_vf_api(struct ixgbe_adapter *adapter,