Patchwork [RFT] sparc: dma-mapping: support debug_dma_mapping_error

login
register
mail settings
Submitter Shuah Khan
Date Oct. 26, 2012, 12:36 a.m.
Message ID <1351211773.6851.24.camel@lorien2>
Download mbox | patch
Permalink /patch/194328/
State Superseded
Delegated to: David Miller
Headers show

Comments

Shuah Khan - Oct. 26, 2012, 12:36 a.m.
From 9e8feb61482288c5a5dd609e0dd17c1a262a48a3 Mon Sep 17 00:00:00 2001
From: Shuah Khan <shuahkhan@gmail.com>
Date: Thu, 25 Oct 2012 18:31:42 -0600
Subject: [PATCH RFT] sparc: dma-mapping: support debug_dma_mapping_error

Add support for debug_dma_mapping_error() call to avoid warning from
debug_dma_unmap() interface when it checks for mapping error checked
status. Without this patch, device driver failed to check map error
warning is generated.

Signed-off-by: Shuah Khan <shuah.khan@hp.com>
---
 arch/sparc/include/asm/dma-mapping.h |    1 +
 1 file changed, 1 insertion(+)
Joerg Roedel - Nov. 17, 2012, 12:22 p.m.
On Thu, Oct 25, 2012 at 06:36:13PM -0600, Shuah Khan wrote:
> >From 9e8feb61482288c5a5dd609e0dd17c1a262a48a3 Mon Sep 17 00:00:00 2001
> From: Shuah Khan <shuahkhan@gmail.com>
> Date: Thu, 25 Oct 2012 18:31:42 -0600
> Subject: [PATCH RFT] sparc: dma-mapping: support debug_dma_mapping_error
> 
> Add support for debug_dma_mapping_error() call to avoid warning from
> debug_dma_unmap() interface when it checks for mapping error checked
> status. Without this patch, device driver failed to check map error
> warning is generated.
> 
> Signed-off-by: Shuah Khan <shuah.khan@hp.com>

Applied to dma-debug, thanks.

Btw, what about the patches for the other archs? They should depend on
the dma-debug branch too and should also be there, no?


	Joerg


--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/sparc/include/asm/dma-mapping.h b/arch/sparc/include/asm/dma-mapping.h
index 8493fd3..05fe53f 100644
--- a/arch/sparc/include/asm/dma-mapping.h
+++ b/arch/sparc/include/asm/dma-mapping.h
@@ -59,6 +59,7 @@  static inline void dma_free_attrs(struct device *dev, size_t size,
 
 static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
 {
+	debug_dma_mapping_error(dev, dma_addr);
 	return (dma_addr == DMA_ERROR_CODE);
 }