Patchwork [2/2] Makefile.am: enable -Wextra

login
register
mail settings
Submitter Colin King
Date Oct. 25, 2012, 1:22 p.m.
Message ID <1351171352-29606-3-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/194152/
State Accepted
Headers show

Comments

Colin King - Oct. 25, 2012, 1:22 p.m.
From: Colin Ian King <colin.king@canonical.com>

Enable -Wextra to catch any sloppy code. Let us be pedantic now.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/Makefile.am |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Alex Hung - Oct. 29, 2012, 6:48 a.m.
On 10/25/2012 09:22 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Enable -Wextra to catch any sloppy code. Let us be pedantic now.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/Makefile.am |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index b7adc20..e82c7a9 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -6,7 +6,7 @@
>   # but libfwts.so depends on libraries produced by acpica/source/compiler.
>   SUBDIRS = acpica/source/compiler lib acpica
>
> -AM_CPPFLAGS = -I$(top_srcdir)/src/lib/include -I$(top_srcdir)/src/acpica/source/include -I$(top_srcdir)/efi_runtime -Wall -Werror
> +AM_CPPFLAGS = -I$(top_srcdir)/src/lib/include -I$(top_srcdir)/src/acpica/source/include -I$(top_srcdir)/efi_runtime -Wall -Werror -Wextra
>
>   bin_PROGRAMS = fwts
>   fwts_SOURCES = main.c \
>
Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu - Oct. 31, 2012, 11:21 a.m.
On 10/25/2012 09:22 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Enable -Wextra to catch any sloppy code. Let us be pedantic now.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/Makefile.am |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index b7adc20..e82c7a9 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -6,7 +6,7 @@
>   # but libfwts.so depends on libraries produced by acpica/source/compiler.
>   SUBDIRS = acpica/source/compiler lib acpica
>
> -AM_CPPFLAGS = -I$(top_srcdir)/src/lib/include -I$(top_srcdir)/src/acpica/source/include -I$(top_srcdir)/efi_runtime -Wall -Werror
> +AM_CPPFLAGS = -I$(top_srcdir)/src/lib/include -I$(top_srcdir)/src/acpica/source/include -I$(top_srcdir)/efi_runtime -Wall -Werror -Wextra
>
>   bin_PROGRAMS = fwts
>   fwts_SOURCES = main.c \
>


Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/Makefile.am b/src/Makefile.am
index b7adc20..e82c7a9 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -6,7 +6,7 @@ 
 # but libfwts.so depends on libraries produced by acpica/source/compiler.
 SUBDIRS = acpica/source/compiler lib acpica
  
-AM_CPPFLAGS = -I$(top_srcdir)/src/lib/include -I$(top_srcdir)/src/acpica/source/include -I$(top_srcdir)/efi_runtime -Wall -Werror
+AM_CPPFLAGS = -I$(top_srcdir)/src/lib/include -I$(top_srcdir)/src/acpica/source/include -I$(top_srcdir)/efi_runtime -Wall -Werror -Wextra
 
 bin_PROGRAMS = fwts
 fwts_SOURCES = main.c \