Patchwork [3/3] lib: Makefile.am: enable -Wextra

login
register
mail settings
Submitter Colin King
Date Oct. 25, 2012, 10:48 a.m.
Message ID <1351162111-31669-4-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/194112/
State Accepted
Headers show

Comments

Colin King - Oct. 25, 2012, 10:48 a.m.
From: Colin Ian King <colin.king@canonical.com>

I want to catch as many possible coding errors, so crank up the
warning pedantry setting to -Wextra

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/Makefile.am |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Alex Hung - Oct. 29, 2012, 6:45 a.m.
On 10/25/2012 06:48 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> I want to catch as many possible coding errors, so crank up the
> warning pedantry setting to -Wextra
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/lib/src/Makefile.am |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/Makefile.am b/src/lib/src/Makefile.am
> index 3f8764e..288ecad 100644
> --- a/src/lib/src/Makefile.am
> +++ b/src/lib/src/Makefile.am
> @@ -2,7 +2,7 @@ AM_CPPFLAGS = \
>   	-I$(top_srcdir)/src/lib/include \
>   	-I$(top_srcdir)/src/acpica/source/include \
>   	-I$(top_srcdir)/src/acpica/source/compiler \
> -	-Wall -Werror
> +	-Wall -Werror -Wextra
>
>   pkglib_LTLIBRARIES = libfwts.la
>   libfwts_la_LDFLAGS = -lpcre -lpthread -ljson -version-info 1:0:0 \
>
Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu - Oct. 29, 2012, 5:35 p.m.
On 10/25/2012 06:48 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> I want to catch as many possible coding errors, so crank up the
> warning pedantry setting to -Wextra
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/lib/src/Makefile.am |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/Makefile.am b/src/lib/src/Makefile.am
> index 3f8764e..288ecad 100644
> --- a/src/lib/src/Makefile.am
> +++ b/src/lib/src/Makefile.am
> @@ -2,7 +2,7 @@ AM_CPPFLAGS = \
>   	-I$(top_srcdir)/src/lib/include \
>   	-I$(top_srcdir)/src/acpica/source/include \
>   	-I$(top_srcdir)/src/acpica/source/compiler \
> -	-Wall -Werror
> +	-Wall -Werror -Wextra
>
>   pkglib_LTLIBRARIES = libfwts.la
>   libfwts_la_LDFLAGS = -lpcre -lpthread -ljson -version-info 1:0:0 \
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/lib/src/Makefile.am b/src/lib/src/Makefile.am
index 3f8764e..288ecad 100644
--- a/src/lib/src/Makefile.am
+++ b/src/lib/src/Makefile.am
@@ -2,7 +2,7 @@  AM_CPPFLAGS = \
 	-I$(top_srcdir)/src/lib/include \
 	-I$(top_srcdir)/src/acpica/source/include \
 	-I$(top_srcdir)/src/acpica/source/compiler \
-	-Wall -Werror
+	-Wall -Werror -Wextra
 
 pkglib_LTLIBRARIES = libfwts.la
 libfwts_la_LDFLAGS = -lpcre -lpthread -ljson -version-info 1:0:0 \