Patchwork [v2] fluxbox: select xmodmap

login
register
mail settings
Submitter Yegor Yefremov
Date Oct. 25, 2012, 10:40 a.m.
Message ID <1351161652-9231-1-git-send-email-yegorslists@googlemail.com>
Download mbox | patch
Permalink /patch/194109/
State Accepted
Commit 0f12f2902372658a657f3df306b16a4a5be4888b
Headers show

Comments

Yegor Yefremov - Oct. 25, 2012, 10:40 a.m.
From: Yegor Yefremov <yegorslists@googlemail.com>

Fluxbox uses xmodmap in its startup script.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
v2: add comment to the Config.in (Thomas Petazzoni)

 package/fluxbox/Config.in |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Thomas Petazzoni - Oct. 25, 2012, 10:44 a.m.
Dear yegorslists@googlemail.com,

On Thu, 25 Oct 2012 12:40:52 +0200, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Fluxbox uses xmodmap in its startup script.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Arnout Vandecappelle - Oct. 26, 2012, 7:27 a.m.
On 25/10/12 12:40, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov<yegorslists@googlemail.com>
>
> Fluxbox uses xmodmap in its startup script.

  I'm not so sure...  The user could change the startup script to remove the
xmodmap (e.g. for a keyboardless device), but now you take away the
possibility to build without it.

  OTOH, xmodmap is so small compared to (tiny)X that it shouldn't matter much.

  Regards,
  Arnout

Patch

diff --git a/package/fluxbox/Config.in b/package/fluxbox/Config.in
index e4d6c37..588e83b 100644
--- a/package/fluxbox/Config.in
+++ b/package/fluxbox/Config.in
@@ -3,6 +3,8 @@  config BR2_PACKAGE_FLUXBOX
 	depends on BR2_PACKAGE_XORG7
 	depends on BR2_INSTALL_LIBSTDCPP
 	select BR2_PACKAGE_XLIB_LIBX11
+	# Runtime dependency, needed by startup script
+	select BR2_PACKAGE_XAPP_XMODMAP
 	help
 	  The Fluxbox lightweight window manager for X