From patchwork Thu Oct 25 05:44:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Hu X-Patchwork-Id: 194043 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id B8A652C0080 for ; Thu, 25 Oct 2012 16:44:33 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TRGF6-0002no-Ew; Thu, 25 Oct 2012 05:44:32 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TRGF3-0002nj-9T for fwts-devel@lists.ubuntu.com; Thu, 25 Oct 2012 05:44:30 +0000 Received: from [175.41.48.77] (helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1TRGF2-000360-MO; Thu, 25 Oct 2012 05:44:29 +0000 From: Ivan Hu To: fwts-devel@lists.ubuntu.com Subject: [PATCH] klog: change the MSR_IA32_ENERGY_PERF_BIAS test from fauilure to info Date: Thu, 25 Oct 2012 13:44:26 +0800 Message-Id: <1351143866-4518-1-git-send-email-ivan.hu@canonical.com> X-Mailer: git-send-email 1.7.10.4 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: fwts-devel-bounces@lists.ubuntu.com Errors-To: fwts-devel-bounces@lists.ubuntu.com Intel IA32 program guild doesn't mention that this MSR should be set by firmare, instead, it mentions "Software can use whatever criteria it sees fit to program the MSR with the appropriate value.". Discuss with IBV (AMI), they'd like to keep this MSR as default, and let OS to change value if desired. Signed-off-by: Ivan Hu Acked-by: Alex Hung Acked-by: Colin Ian King --- data/klog.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/data/klog.json b/data/klog.json index 653b592..65d4545 100644 --- a/data/klog.json +++ b/data/klog.json @@ -76,10 +76,10 @@ }, { "compare_mode": "regex", - "log_level": "LOG_LEVEL_HIGH", + "log_level": "LOG_LEVEL_INFO", "tag": "FWTS_TAG_BIOS", "pattern": "ENERGY_PERF_BIAS.*Set to 'normal'.* was 'performance'", - "advice": "The MSR_IA32_ENERGY_PERF_BIAS was initialized incorrectly and was defaulted to a high performance bias setting. The kernel has detected this and changed it down to a 'normal' bias setting. The BIOS vendor should be informed that the MSR is not defaulted to the normal bias setting." + "advice": "This is not exactly a failure but a warning from the kernel. The MSR_IA32_ENERGY_PERF_BIAS was initialized and defaulted to a high performance bias setting. The kernel has detected this and changed it down to a 'normal' bias setting." }, { "compare_mode": "regex",