Patchwork klog: change the MSR_IA32_ENERGY_PERF_BIAS test from fauilure to info

login
register
mail settings
Submitter Ivan Hu
Date Oct. 25, 2012, 5:44 a.m.
Message ID <1351143866-4518-1-git-send-email-ivan.hu@canonical.com>
Download mbox | patch
Permalink /patch/194043/
State Accepted
Headers show

Comments

Ivan Hu - Oct. 25, 2012, 5:44 a.m.
Intel IA32 program guild doesn't mention that this MSR should be set by
firmare, instead, it mentions "Software can use whatever criteria it sees
fit to program the MSR with the appropriate value.". Discuss with IBV (AMI),
they'd like to keep this MSR as default, and let OS to change value if desired.

Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
---
 data/klog.json |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Alex Hung - Oct. 25, 2012, 6:27 a.m.
On 10/25/2012 01:44 PM, Ivan Hu wrote:
> Intel IA32 program guild doesn't mention that this MSR should be set by
> firmare, instead, it mentions "Software can use whatever criteria it sees
> fit to program the MSR with the appropriate value.". Discuss with IBV (AMI),
> they'd like to keep this MSR as default, and let OS to change value if desired.
>
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>   data/klog.json |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index 653b592..65d4545 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -76,10 +76,10 @@
>     },
>     {
>      "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> +   "log_level": "LOG_LEVEL_INFO",
>      "tag": "FWTS_TAG_BIOS",
>      "pattern": "ENERGY_PERF_BIAS.*Set to 'normal'.* was 'performance'",
> -   "advice": "The MSR_IA32_ENERGY_PERF_BIAS was initialized incorrectly and was defaulted to a high performance bias setting.  The kernel has detected this and changed it down to a 'normal' bias setting.  The BIOS vendor should be informed that the MSR is not defaulted to the normal bias setting."
> +   "advice": "This is not exactly a failure but a warning from the kernel. The MSR_IA32_ENERGY_PERF_BIAS was initialized and defaulted to a high performance bias setting. The kernel has detected this and changed it down to a 'normal' bias setting."
>     },
>     {
>      "compare_mode": "regex",
>
Acked-by: Alex Hung <alex.hung@canonical.com>
Colin King - Oct. 25, 2012, 8:53 a.m.
On 25/10/12 06:44, Ivan Hu wrote:
> Intel IA32 program guild doesn't mention that this MSR should be set by
> firmare, instead, it mentions "Software can use whatever criteria it sees
> fit to program the MSR with the appropriate value.". Discuss with IBV (AMI),
> they'd like to keep this MSR as default, and let OS to change value if desired.
>
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>   data/klog.json |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index 653b592..65d4545 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -76,10 +76,10 @@
>     },
>     {
>      "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> +   "log_level": "LOG_LEVEL_INFO",
>      "tag": "FWTS_TAG_BIOS",
>      "pattern": "ENERGY_PERF_BIAS.*Set to 'normal'.* was 'performance'",
> -   "advice": "The MSR_IA32_ENERGY_PERF_BIAS was initialized incorrectly and was defaulted to a high performance bias setting.  The kernel has detected this and changed it down to a 'normal' bias setting.  The BIOS vendor should be informed that the MSR is not defaulted to the normal bias setting."
> +   "advice": "This is not exactly a failure but a warning from the kernel. The MSR_IA32_ENERGY_PERF_BIAS was initialized and defaulted to a high performance bias setting. The kernel has detected this and changed it down to a 'normal' bias setting."
>     },
>     {
>      "compare_mode": "regex",
>

That's a useful insight. And since the kernel can change this then we 
can always get to a more optimal energy configuration w/o any firmware 
changes, so yes, lets make this an INFO message.

Acked-by: Colin Ian King <colin.king@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index 653b592..65d4545 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -76,10 +76,10 @@ 
   },
   {
    "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_HIGH",
+   "log_level": "LOG_LEVEL_INFO",
    "tag": "FWTS_TAG_BIOS",
    "pattern": "ENERGY_PERF_BIAS.*Set to 'normal'.* was 'performance'",
-   "advice": "The MSR_IA32_ENERGY_PERF_BIAS was initialized incorrectly and was defaulted to a high performance bias setting.  The kernel has detected this and changed it down to a 'normal' bias setting.  The BIOS vendor should be informed that the MSR is not defaulted to the normal bias setting."
+   "advice": "This is not exactly a failure but a warning from the kernel. The MSR_IA32_ENERGY_PERF_BIAS was initialized and defaulted to a high performance bias setting. The kernel has detected this and changed it down to a 'normal' bias setting."
   },
   {
    "compare_mode": "regex",