From patchwork Tue Oct 23 15:54:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greta Yorsh X-Patchwork-Id: 193520 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 523B12C0109 for ; Wed, 24 Oct 2012 02:55:10 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1351612511; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=AUefjC90zdeZ4vM9n6Cy nyUsRHk=; b=uRUYYOpUlwPsKmzTBYCdKm+uNmunn2BFBesXMF6G3SOaAnPbS8zk 2H9vP5sjHXzsiOBQYq2LDZQH3ch2abayAOlamG4e8AXUBkHviJI1+kGihmwAUo5y AlXtIUmeWGWB53BUqQW2WBpvPbOZC+gXxpGXaAieW7A/UGnPS1Y9a24= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:From:To:Cc:Subject:Date:Message-ID:MIME-Version:X-MC-Unique:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=BnuNH2ownrjE5FU6XEWPqedXfkADJ8SwWF3pA7JTWzLjfJ0gG26gOKut0IOyIF PSmU4LKgMowzuoPG9WL7jeLiTd/ex0ZZNjkKT8r9aw273MPxREr8mgzL/acBQeT4 R5wjGHkOx8ylbgfiHFhVGVVyQL48DygDkZlm4iDPDGBhg=; Received: (qmail 12397 invoked by alias); 23 Oct 2012 15:55:07 -0000 Received: (qmail 12389 invoked by uid 22791); 23 Oct 2012 15:55:06 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, MSGID_MULTIPLE_AT, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Oct 2012 15:54:59 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 23 Oct 2012 16:54:55 +0100 Received: from e103227vm ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Tue, 23 Oct 2012 16:54:54 +0100 From: "Greta Yorsh" To: "GCC Patches" Cc: "Ramana Radhakrishnan" , "Richard Earnshaw" , , Subject: [PATCH, ARM] Fix offset_ok_for_ldrd_strd in Thumb1 Date: Tue, 23 Oct 2012 16:54:50 +0100 Message-ID: <000001cdb136$bc565fe0$35031fa0$@yorsh@arm.com> MIME-Version: 1.0 X-MC-Unique: 112102316545508401 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org The function offset_ok_for_ldrd_strd should return false for Thumb1, because TARGET_LDRD and Thumb1 can be both enabled (for example, the default for cortex-m0). This patch fixes ICE that is caused by gcc r192678 and occurs when building gcc with newlib for arm-none-eabi cortex-m0. Ok for trunk? Thanks, Greta ChangeLog gcc/ 2012-10-23 Greta Yorsh * config/arm/arm.c (offset_ok_for_ldrd_strd): Return false for Thumb1. diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index e9b9463..a94e537 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -12209,7 +12209,7 @@ offset_ok_for_ldrd_strd (HOST_WIDE_INT offset) else if (TARGET_ARM) max_offset = 255; else - gcc_unreachable (); + return false; return ((offset <= max_offset) && (offset >= -max_offset)); }