Patchwork [PULL,00/29] qemu-sockets error propagation + NBD server

login
register
mail settings
Submitter Paolo Bonzini
Date Oct. 23, 2012, 12:34 p.m.
Message ID <50868EC4.7050205@redhat.com>
Download mbox | patch
Permalink /patch/193473/
State New
Headers show

Comments

Paolo Bonzini - Oct. 23, 2012, 12:34 p.m.
Il 22/10/2012 21:53, Anthony Liguori ha scritto:
>   LINK  vscclient
> qemu-tool.o: In function `monitor_get_fd':
> /home/anthony/git/qemu/qemu-tool.c:53: undefined reference to `error_set'
> collect2: ld returned 1 exit status
> make: *** [vscclient] Error 1
> 
> Even tried a clean build and get the same error.

Fixed like this and pushed to the same place (tip is now commit
8b5c3381d28ebb1765f17a4cbe1852d3b68b7dc4).  Sorry.

I will try to clean up the dependencies before or during soft feature
freeze.

Paolo
Paolo Bonzini - Oct. 23, 2012, 3:27 p.m.
Il 23/10/2012 14:34, Paolo Bonzini ha scritto:
> Fixed like this and pushed to the same place (tip is now commit
> 8b5c3381d28ebb1765f17a4cbe1852d3b68b7dc4).  Sorry.
> 
> I will try to clean up the dependencies before or during soft feature
> freeze.

Nevermind, still broken. :(

Paolo
Paolo Bonzini - Oct. 23, 2012, 9:24 p.m.
On Tue, Oct 23, 2012 at 5:27 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 23/10/2012 14:34, Paolo Bonzini ha scritto:
>> Fixed like this and pushed to the same place (tip is now commit
>> 8b5c3381d28ebb1765f17a4cbe1852d3b68b7dc4).  Sorry.
>>
>> I will try to clean up the dependencies before or during soft feature
>> freeze.
>
> Nevermind, still broken. :(

It's fixed now (actually a couple hours ago :)).

Paolo

Patch

diff --git a/Makefile b/Makefile
index 88285a4..2a33868 100644
--- a/Makefile
+++ b/Makefile
@@ -171,7 +171,8 @@  qemu-io$(EXESUF): qemu-io.o cmd.o $(tools-obj-y) $(block-obj-y)
 
 qemu-bridge-helper$(EXESUF): qemu-bridge-helper.o
 
-vscclient$(EXESUF): $(libcacard-y) $(oslib-obj-y) $(trace-obj-y) $(tools-obj-y) qemu-timer-common.o libcacard/vscclient.o
+vscclient$(EXESUF): $(libcacard-y) $(oslib-obj-y) $(trace-obj-y) \
+	error.o $(tools-obj-y) qemu-timer-common.o libcacard/vscclient.o
 	$(call quiet-command,$(CC) $(LDFLAGS) -o $@ $^ $(libcacard_libs) $(LIBS),"  LINK  $@")
 
 fsdev/virtfs-proxy-helper$(EXESUF): fsdev/virtfs-proxy-helper.o fsdev/virtio-9p-marshal.o oslib-posix.o $(trace-obj-y)