From patchwork Tue Oct 23 06:08:48 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 193362 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6A7502C00A6 for ; Tue, 23 Oct 2012 17:09:14 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752788Ab2JWGIx (ORCPT ); Tue, 23 Oct 2012 02:08:53 -0400 Received: from mail-ea0-f174.google.com ([209.85.215.174]:65129 "EHLO mail-ea0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751724Ab2JWGIw (ORCPT ); Tue, 23 Oct 2012 02:08:52 -0400 Received: by mail-ea0-f174.google.com with SMTP id c13so1036227eaa.19 for ; Mon, 22 Oct 2012 23:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; bh=KoThfT/3Y+Pc6OfnhTDGnDkl0UtE0FavfjxIPJO2rOU=; b=KlIXFN6oyM4KX3Hrf9uUrdVu/BIpCtBrTEcNEvjYzd7QfYTxLRkUuDw3Re58aWZR04 OBmnWKsIwGX9bJSMr6TXPSWpoJDYKzXNEUpiNB4x/hpBSHcaIPh6oHWGiP+vfqlQkhgX kAYpKDwWfRhomZ9KRvDTjnz2h0ABSCrs20S238f56ENCn6sBy74RKNB/6H5cWWRGTwnG QtcLny+PCm8U+uklvNil/crQqzlmDbRnQchyo/ZiDNDRlJqPi84nNgsXihxus82AQ1Rs ySKJYdPfPBAROzCBvmxNx/NKXEh4jbmsSNb9vl3it+9PAY51Htp7An6z6CYetgf0mM1b jInA== Received: by 10.14.223.199 with SMTP id v47mr15292260eep.45.1350972531238; Mon, 22 Oct 2012 23:08:51 -0700 (PDT) Received: from [172.28.91.48] ([172.28.91.48]) by mx.google.com with ESMTPS id 7sm19141251eeg.5.2012.10.22.23.08.49 (version=SSLv3 cipher=OTHER); Mon, 22 Oct 2012 23:08:50 -0700 (PDT) Subject: Re: 3.7-rc2 regression : file copied to CIFS-mounted directory corrupted From: Eric Dumazet To: jongman.heo@samsung.com Cc: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "edumazet@google.com" In-Reply-To: <22207427.56211350970373630.JavaMail.weblogic@epml04> References: <22207427.56211350970373630.JavaMail.weblogic@epml04> Date: Tue, 23 Oct 2012 08:08:48 +0200 Message-ID: <1350972528.8609.1431.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 2012-10-23 at 05:38 +0000, Jongman Heo wrote: > Hmm, > > I've just met the issue, with the commit 5640f768 reverted. > It seems that the issue does not always happen. So, my bisection may not be correct. > > At this moment, I don't have enough time to do bisection again.. > > Regards. What happens, if instead of reverting you try the following ? If this solves the problem, then we shall find the driver that assumes frags are order-0 pages only. --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/core/sock.c b/net/core/sock.c index 8a146cf..a743e7c 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -1726,7 +1726,7 @@ struct sk_buff *sock_alloc_send_skb(struct sock *sk, unsigned long size, EXPORT_SYMBOL(sock_alloc_send_skb); /* On 32bit arches, an skb frag is limited to 2^15 */ -#define SKB_FRAG_PAGE_ORDER get_order(32768) +#define SKB_FRAG_PAGE_ORDER 0 bool sk_page_frag_refill(struct sock *sk, struct page_frag *pfrag) {