Message ID | 1350922776-30909-1-git-send-email-swarren@wwwdotorg.org |
---|---|
State | Accepted |
Delegated to: | Albert ARIBAUD |
Headers | show |
On Mon, Oct 22, 2012 at 9:19 AM, Stephen Warren <swarren@wwwdotorg.org> wrote: > From: Stephen Warren <swarren@nvidia.com> > > When -ffunction-sections or -fdata-section are used, symbols are placed > into sections such as .data.eserial1_device and .bss.serial_current. > Update the linker script to explicitly include these. Without this > change (at least with my gcc-4.5.3 built using crosstool-ng), I see that > the sections do end up being included, but __bss_end__ gets set to the > same value as __bss_start. > > Signed-off-by: Stephen Warren <swarren@nvidia.com> > Acked-by: Allen Martin <amartin@nvidia.com> I tested this series on seaboard. Acked-by: Simon Glass <sjg@chromium.org> Tested-by: Simon Glass <sjg@chromium.org> Regards, Simon
Hi Simon, On Thu, 25 Oct 2012 11:11:14 -0700, Simon Glass <sjg@chromium.org> wrote: > On Mon, Oct 22, 2012 at 9:19 AM, Stephen Warren <swarren@wwwdotorg.org> wrote: > > From: Stephen Warren <swarren@nvidia.com> > > > > When -ffunction-sections or -fdata-section are used, symbols are placed > > into sections such as .data.eserial1_device and .bss.serial_current. > > Update the linker script to explicitly include these. Without this > > change (at least with my gcc-4.5.3 built using crosstool-ng), I see that > > the sections do end up being included, but __bss_end__ gets set to the > > same value as __bss_start. > > > > Signed-off-by: Stephen Warren <swarren@nvidia.com> > > Acked-by: Allen Martin <amartin@nvidia.com> > > I tested this series on seaboard. > > Acked-by: Simon Glass <sjg@chromium.org> > Tested-by: Simon Glass <sjg@chromium.org> > > Regards, > Simon > Applied (this patch only in the series) to u-boot-arm/master, thanks! Amicalement,
diff --git a/arch/arm/cpu/u-boot.lds b/arch/arm/cpu/u-boot.lds index e49ca0c..9153c3d 100644 --- a/arch/arm/cpu/u-boot.lds +++ b/arch/arm/cpu/u-boot.lds @@ -34,8 +34,8 @@ SECTIONS .text : { __image_copy_start = .; - CPUDIR/start.o (.text) - *(.text) + CPUDIR/start.o (.text*) + *(.text*) } . = ALIGN(4); @@ -43,7 +43,7 @@ SECTIONS . = ALIGN(4); .data : { - *(.data) + *(.data*) } . = ALIGN(4); @@ -81,7 +81,7 @@ SECTIONS .bss __rel_dyn_start (OVERLAY) : { __bss_start = .; - *(.bss) + *(.bss*) . = ALIGN(4); __bss_end__ = .; }