Patchwork [12/12] arptables: add new package

login
register
mail settings
Submitter Gustavo Zacarias
Date Oct. 22, 2012, 12:46 p.m.
Message ID <1350909989-1012-12-git-send-email-gustavo@zacarias.com.ar>
Download mbox | patch
Permalink /patch/193153/
State Accepted
Commit efc10eb6b87884f1f7917462d78af6953fcd99e3
Headers show

Comments

Gustavo Zacarias - Oct. 22, 2012, 12:46 p.m.
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/Config.in              |    1 +
 package/arptables/Config.in    |    6 ++++++
 package/arptables/arptables.mk |   21 +++++++++++++++++++++
 3 files changed, 28 insertions(+), 0 deletions(-)
 create mode 100644 package/arptables/Config.in
 create mode 100644 package/arptables/arptables.mk
Arnout Vandecappelle - Oct. 24, 2012, 8:59 p.m.
On 22/10/12 14:46, Gustavo Zacarias wrote:
[snip]
> +ARPTABLES_VERSION = 0.0.3
> +ARPTABLES_VERSION_MINOR = 4
> +ARPTABLES_SOURCE = arptables-v$(ARPTABLES_VERSION)-$(ARPTABLES_VERSION_MINOR).tar.gz
> +ARPTABLES_SITE =http://downloads.sourceforge.net/project/ebtables/arptables/arptables-v$(ARPTABLES_VERSION)

  We usually put
ARPTABLES_VERSION_MAJOR = v0.0.3
ARPTABLES_VERSION = $(ARPTABLES_VERSION_MAJOR)-4
ARPTABLES_SITE =http://downloads.sourceforge.net/project/ebtables/arptables/arptables-$(ARPTABLES_VERSION_MAJOR)

(_SITE is at its default value)

  I can't say if that's really better, though :-)

  Regards,
  Arnout
Gustavo Zacarias - Oct. 24, 2012, 9:10 p.m.
On 10/24/12 17:59, Arnout Vandecappelle wrote:

>  We usually put
> ARPTABLES_VERSION_MAJOR = v0.0.3
> ARPTABLES_VERSION = $(ARPTABLES_VERSION_MAJOR)-4
> ARPTABLES_SITE
> =http://downloads.sourceforge.net/project/ebtables/arptables/arptables-$(ARPTABLES_VERSION_MAJOR)
> 
> 
> (_SITE is at its default value)
> 
>  I can't say if that's really better, though :-)
> 
>  Regards,
>  Arnout

In some cases it's also _MAJOR & _MINOR.
Dunno what's preferred, it seems overkill to use soo many zeros for very
few versions released :)
Regards.

Patch

diff --git a/package/Config.in b/package/Config.in
index 7c29ef3..5cbebbc 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -540,6 +540,7 @@  endmenu
 
 menu "Networking applications"
 source "package/argus/Config.in"
+source "package/arptables/Config.in"
 source "package/avahi/Config.in"
 source "package/axel/Config.in"
 source "package/bluez_utils/Config.in"
diff --git a/package/arptables/Config.in b/package/arptables/Config.in
new file mode 100644
index 0000000..510eedf
--- /dev/null
+++ b/package/arptables/Config.in
@@ -0,0 +1,6 @@ 
+config BR2_PACKAGE_ARPTABLES
+	bool "arptables"
+	help
+	  Tool to set up, maintain, and inspect the tables of ARP rules.
+
+	  http://ebtables.sourceforge.net
diff --git a/package/arptables/arptables.mk b/package/arptables/arptables.mk
new file mode 100644
index 0000000..dac5ca4
--- /dev/null
+++ b/package/arptables/arptables.mk
@@ -0,0 +1,21 @@ 
+#############################################################
+#
+# arptables
+#
+#############################################################
+
+ARPTABLES_VERSION = 0.0.3
+ARPTABLES_VERSION_MINOR = 4
+ARPTABLES_SOURCE = arptables-v$(ARPTABLES_VERSION)-$(ARPTABLES_VERSION_MINOR).tar.gz
+ARPTABLES_SITE = http://downloads.sourceforge.net/project/ebtables/arptables/arptables-v$(ARPTABLES_VERSION)
+
+define ARPTABLES_BUILD_CMDS
+	$(MAKE) -C $(@D) \
+		CC="$(TARGET_CC)" COPT_FLAGS="$(TARGET_CFLAGS)"
+endef
+
+define ARPTABLES_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 755 -D $(@D)/arptables $(TARGET_DIR)/usr/sbin/arptables
+endef
+
+$(eval $(generic-package))