Patchwork [v2,6/6] pflash_cfi01: Fix debug mode printfery

login
register
mail settings
Submitter Peter Crosthwaite
Date Oct. 22, 2012, 7:19 a.m.
Message ID <328e37d8b174defe95f83a914859e2d9d804ae7d.1350889929.git.peter.crosthwaite@xilinx.com>
Download mbox | patch
Permalink /patch/193090/
State New
Headers show

Comments

Peter Crosthwaite - Oct. 22, 2012, 7:19 a.m.
This DPRINTF was throwing a warning due to a missing cast.

Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---

 hw/pflash_cfi01.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Peter Maydell - Oct. 22, 2012, 4:17 p.m.
On 22 October 2012 08:19, Peter Crosthwaite
<peter.crosthwaite@xilinx.com> wrote:
> This DPRINTF was throwing a warning due to a missing cast.
>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

If you stick this earlier in the series with the other pflash
patches they can easily be applied even if we're still arguing
about the pl35x bits.

-- PMM

Patch

diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c
index 6164a97..90c111d 100644
--- a/hw/pflash_cfi01.c
+++ b/hw/pflash_cfi01.c
@@ -183,7 +183,8 @@  static uint32_t pflash_read (pflash_t *pfl, target_phys_addr_t offset,
             DPRINTF("%s: Device ID Code %04x\n", __func__, ret);
             break;
         default:
-            DPRINTF("%s: Read Device Information boff=%x\n", __func__, boff);
+            DPRINTF("%s: Read Device Information boff=%x\n", __func__,
+                    (unsigned)boff);
             ret = 0;
             break;
         }